Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

[Ilya Yanok]

  Hi Kumar, Kim, Josh, everybody,

I hope to disturb you but I haven't got any reply for my first posting...

I've found that MSI work correctly with older kernels on my MPC8308RDB 
board and don't work with newer ones. After bisecting I've found that 
the source of the problem is commit 3da34aa:

commit 3da34aae03d498ee62f75aa7467de93cce3030fd
Author: Kumar Gala <galak@kernel.crashing.org>
Date:   Tue May 12 15:51:56 2009 -0500

     powerpc/fsl: Support unique MSI addresses per PCIe Root Complex

     Its feasible based on how the PCI address map is setup that the region
     of PCI address space used for MSIs differs for each PHB on the same 
SoC.

     Instead of assuming that the address mappes to CCSRBAR 1:1 we read
     PEXCSRBAR (BAR0) for the PHB that the given pci_dev is on.

     Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

I can see BAR0 initialization for 85xx/86xx hardware but not for 83xx 
neigher in the kernel nor in U-Boot (that makes me think that all 83xx 
can be affected).
I'm not actually an PCI expert so I've just tried to write IMMR base 
address to the BAR0 register from the U-Boot to get the correct address 
but this doesn't help.
Please direct me how to init 83xx PCIE controller to make it compatible 
with this patch.

Kim, I think MPC8315E is affected too, could you please test it?

Thanks in advance.

Regards, Ilya.

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

[Ilya Yanok]

  23.07.2010 1:09, Ilya Yanok wrote:
> I hope to disturb you but I haven't got any reply for my first posting...

I shouldn't be working at night... It's 'hate' not 'hope'...

Regards, Ilya.

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

[Kumar Gala]

On Jul 22, 2010, at 4:11 PM, Ilya Yanok wrote:

> 23.07.2010 1:09, Ilya Yanok wrote:
>> I hope to disturb you but I haven't got any reply for my first posting...
> 
> I shouldn't be working at night... It's 'hate' not 'hope'...
> 
> Regards, Ilya.

I have a fix, can you test?

- k

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

[Ilya Yanok]

  Hi Kumar,

05.08.2010 11:01, Kumar Gala пишет:
> I have a fix, can you test?

Surely. Where can I find it?

Thanks.

Regards, Ilya.

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

[Kumar Gala]

On Aug 5, 2010, at 3:24 AM, Ilya Yanok wrote:

> Hi Kumar,
>=20
> 05.08.2010 11:01, Kumar Gala =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> I have a fix, can you test?
>=20
> Surely. Where can I find it?
>=20
> Thanks.
>=20
> Regards, Ilya.

http://patchwork.ozlabs.org/patch/60934/

- k

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

[Wolfgang Denk]

Dear Kumar & Kim,

any comments on this issue?

Thanks.

In message <4C48B384.1020006@emcraft.com> Ilya Yanok wrote:
>   Hi Kumar, Kim, Josh, everybody,
> 
> I hope to disturb you but I haven't got any reply for my first posting...
> 
> I've found that MSI work correctly with older kernels on my MPC8308RDB 
> board and don't work with newer ones. After bisecting I've found that 
> the source of the problem is commit 3da34aa:
> 
> commit 3da34aae03d498ee62f75aa7467de93cce3030fd
> Author: Kumar Gala <galak@kernel.crashing.org>
> Date:   Tue May 12 15:51:56 2009 -0500
> 
>      powerpc/fsl: Support unique MSI addresses per PCIe Root Complex
> 
>      Its feasible based on how the PCI address map is setup that the region
>      of PCI address space used for MSIs differs for each PHB on the same 
> SoC.
> 
>      Instead of assuming that the address mappes to CCSRBAR 1:1 we read
>      PEXCSRBAR (BAR0) for the PHB that the given pci_dev is on.
> 
>      Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> 
> I can see BAR0 initialization for 85xx/86xx hardware but not for 83xx 
> neigher in the kernel nor in U-Boot (that makes me think that all 83xx 
> can be affected).
> I'm not actually an PCI expert so I've just tried to write IMMR base 
> address to the BAR0 register from the U-Boot to get the correct address 
> but this doesn't help.
> Please direct me how to init 83xx PCIE controller to make it compatible 
> with this patch.
> 
> Kim, I think MPC8315E is affected too, could you please test it?
> 
> Thanks in advance.
> 
> Regards, Ilya.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
A good aphorism is too hard for the tooth of time, and  is  not  worn
away  by  all  the  centuries,  although  it serves as food for every
epoch.                                  - Friedrich Wilhelm Nietzsche
                          _Miscellaneous Maxims and Opinions_ no. 168

Re: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]

[Wolfgang Denk]

Hello Kumar, hello Kim,


can you _please_ comment?  Thanks.

In message <20100729212043.4258C152397@gemini.denx.de> I wrote:
> Dear Kumar & Kim,
> 
> any comments on this issue?
> 
> Thanks.
> 
> In message <4C48B384.1020006@emcraft.com> Ilya Yanok wrote:
> >   Hi Kumar, Kim, Josh, everybody,
> > 
> > I hope to disturb you but I haven't got any reply for my first posting...
> > 
> > I've found that MSI work correctly with older kernels on my MPC8308RDB 
> > board and don't work with newer ones. After bisecting I've found that 
> > the source of the problem is commit 3da34aa:
> > 
> > commit 3da34aae03d498ee62f75aa7467de93cce3030fd
> > Author: Kumar Gala <galak@kernel.crashing.org>
> > Date:   Tue May 12 15:51:56 2009 -0500
> > 
> >      powerpc/fsl: Support unique MSI addresses per PCIe Root Complex
> > 
> >      Its feasible based on how the PCI address map is setup that the region
> >      of PCI address space used for MSIs differs for each PHB on the same SoC.
> > 
> >      Instead of assuming that the address mappes to CCSRBAR 1:1 we read
> >      PEXCSRBAR (BAR0) for the PHB that the given pci_dev is on.
> > 
> >      Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > 
> > I can see BAR0 initialization for 85xx/86xx hardware but not for 83xx 
> > neigher in the kernel nor in U-Boot (that makes me think that all 83xx 
> > can be affected).
> > I'm not actually an PCI expert so I've just tried to write IMMR base 
> > address to the BAR0 register from the U-Boot to get the correct address 
> > but this doesn't help.
> > Please direct me how to init 83xx PCIE controller to make it compatible 
> > with this patch.
> > 
> > Kim, I think MPC8315E is affected too, could you please test it?
> > 
> > Thanks in advance.
> > 
> > Regards, Ilya.
> 
> Best regards,
> 
> Wolfgang Denk


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
In the beginning, there was nothing, which exploded.
                                - Terry Pratchett, _Lords and Ladies_