From: Micha Nelissen <micha@neli.hopto.org>
To: Alexandre Bounine <alexandre.bounine@idt.com>
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] RapidIO: Add switch-specific sysfs initialization callback
Date: Mon, 16 Aug 2010 14:25:48 +0200 [thread overview]
Message-ID: <4C692E4C.4040300@neli.hopto.org> (raw)
In-Reply-To: <1281712686-31308-7-git-send-email-alexandre.bounine@idt.com>
Alexandre Bounine wrote:
> - if (!rdev->rswitch)
> - goto out;
> -
Is it safe? All devices have a switch?
> @@ -63,10 +59,11 @@ struct device_attribute rio_dev_attrs[] = {
> __ATTR_RO(asm_did),
> __ATTR_RO(asm_vid),
> __ATTR_RO(asm_rev),
> - __ATTR_RO(routes),
> __ATTR_NULL,
> };
>
> +static DEVICE_ATTR(routes, S_IRUGO, routes_show, NULL);
> +
This seems a separate change from the sw_sysfs? Why make it separate?
> */
> struct rio_switch {
> @@ -256,6 +257,7 @@ struct rio_switch {
> u8 *sw_domain);
> int (*em_init) (struct rio_dev *dev);
> int (*em_handle) (struct rio_dev *dev, u8 swport);
> + int (*sw_sysfs) (struct rio_dev *dev, int create);
> struct rio_dev *nextdev[0];
> };
Why not make a sw_sysfs_create and sw_sysfs_remove? Is better for
readability. Now you call 'sw_sysfs(dev, 0)' or 'sw_sysfs(dev, 1)';
Micha
next prev parent reply other threads:[~2010-08-16 12:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 15:17 [PATCH 0/9] RapidIO: Set of patches to add Gen2 switches Alexandre Bounine
2010-08-13 15:17 ` [PATCH 1/9] RapidIO: fix RapidIO sysfs hierarchy Alexandre Bounine
2010-08-13 15:17 ` [PATCH 2/9] RapidIO, powerpc/85xx: modify RIO port-write interrupt handler Alexandre Bounine
2010-08-16 12:12 ` Micha Nelissen
2010-08-16 15:27 ` Bounine, Alexandre
2010-08-17 7:12 ` Micha Nelissen
2010-08-17 17:16 ` Bounine, Alexandre
2010-08-13 15:18 ` [PATCH 3/9] RapidIO: Add the ingress port number into the RIO switch data structure Alexandre Bounine
2010-08-16 12:14 ` Micha Nelissen
2010-08-16 13:40 ` Bounine, Alexandre
2010-08-13 15:18 ` [PATCH 4/9] RapidIO: Add relation links between RIO device structures Alexandre Bounine
2010-08-16 12:18 ` Micha Nelissen
2010-08-16 14:00 ` Bounine, Alexandre
2010-08-17 7:08 ` Micha Nelissen
2010-08-17 17:47 ` Bounine, Alexandre
2010-08-13 15:18 ` [PATCH 5/9] RapidIO: Add default handler for error_stopped state Alexandre Bounine
2010-08-16 12:21 ` Micha Nelissen
2010-08-16 14:47 ` Bounine, Alexandre
2010-08-13 15:18 ` [PATCH 6/9] RapidIO: Add switch-specific sysfs initialization callback Alexandre Bounine
2010-08-16 12:25 ` Micha Nelissen [this message]
2010-08-16 17:10 ` Bounine, Alexandre
2010-08-17 7:18 ` Micha Nelissen
2010-08-17 17:20 ` Bounine, Alexandre
2010-08-13 15:18 ` [PATCH 7/9] RapidIO: Add handling for PW message from a lost device Alexandre Bounine
2010-08-16 12:29 ` Micha Nelissen
2010-08-16 18:02 ` Bounine, Alexandre
2010-08-17 7:22 ` Micha Nelissen
2010-08-17 12:44 ` Bounine, Alexandre
2010-08-13 15:18 ` [PATCH 8/9] RapidIO: Add device access check into the enumeration Alexandre Bounine
2010-08-13 15:18 ` [PATCH 9/9] RapidIO: Add support for IDT CPS Gen2 switches Alexandre Bounine
2010-08-16 12:36 ` Micha Nelissen
2010-08-16 18:30 ` Bounine, Alexandre
2010-08-16 12:30 ` [PATCH 0/9] RapidIO: Set of patches to add " Micha Nelissen
2010-08-16 18:18 ` Bounine, Alexandre
2010-08-17 7:31 ` Micha Nelissen
2010-08-17 18:13 ` Bounine, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C692E4C.4040300@neli.hopto.org \
--to=micha@neli.hopto.org \
--cc=akpm@linux-foundation.org \
--cc=alexandre.bounine@idt.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox