From: LEROY Christophe <christophe.leroy@c-s.fr>
To: Kumar Gala <kumar.gala@freescale.com>
Cc: LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Small issue at init with spi_mpc8xxx.c with CPM1
Date: Tue, 07 Sep 2010 11:17:17 +0200 [thread overview]
Message-ID: <4C86031D.5080804@c-s.fr> (raw)
Dear Kumar,
I have a small issue in the init of spi_mpc8xxx.c with MPC866 (CPM1)
Unlike cpm_uart that maps the parameter ram directly using
of_iomap(np,1), spi_mpc8xxx.c uses cpm_muram_alloc_fixed().
This has two impacts in the .dts file:
* The driver must be declared with pram at 1d80 instead of 3d80 whereas
it is not a child of muram@2000 but a child of cpm@9c0
* muram@2000/data@0 must be declared with reg = <0x0 0x2000> whereas
is should be reg=<0x0 0x1c00> to avoid cpm_muram_alloc() to allocate
space from parameters ram.
Maybe I misunderstood something ?
Regards
Christophe Leroy
next reply other threads:[~2010-09-07 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 9:17 LEROY Christophe [this message]
2010-09-07 20:00 ` Small issue at init with spi_mpc8xxx.c with CPM1 Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C86031D.5080804@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).