From: Timur Tabi <timur@freescale.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: kumar.gala@freescale.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, amit.shah@redhat.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full
Date: Tue, 14 Sep 2010 14:25:34 -0500 [thread overview]
Message-ID: <4C8FCC2E.1020107@freescale.com> (raw)
In-Reply-To: <20100914204410.71942cdc@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> Its a printk handler - better to lose the bytes than hang the box. I
> think the current code is probably right.
What do you think about this change:
http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-October/thread.html#76830
This is the original version of my patch. In it, I simply allow drivers to
return 0 to indicate that they're too busy to accept data. It works great
on the hvc driver that we have in-house today, but it might break other
drivers that return 0 to indicate error.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-09-14 19:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 18:45 [PATCH] hvc_console: fix dropping of characters when output byte channel is full Timur Tabi
2010-09-14 16:05 ` Timur Tabi
2010-09-14 19:17 ` Andrew Morton
2010-09-14 19:22 ` Scott Wood
2010-09-14 19:44 ` Alan Cox
2010-09-14 19:25 ` Timur Tabi [this message]
2010-09-14 19:52 ` Alan Cox
2010-09-14 19:44 ` Timur Tabi
2010-09-14 20:05 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8FCC2E.1020107@freescale.com \
--to=timur@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=amit.shah@redhat.com \
--cc=kumar.gala@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).