From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.j.williams@intel.com>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by ozlabs.org (Postfix) with ESMTP id 5B2BBB70E3
	for <linuxppc-dev@lists.ozlabs.org>;
	Fri, 24 Sep 2010 08:48:46 +1000 (EST)
Message-ID: <4C9BD94B.8030203@intel.com>
Date: Thu, 23 Sep 2010 15:48:43 -0700
From: Dan Williams <dan.j.williams@intel.com>
MIME-Version: 1.0
To: "tmarri@apm.com" <tmarri@apm.com>
Subject: Re: [PATCH v1 3/4] PPC4xx: New file with SoC specific functions
References: <1285279906-16819-1-git-send-email-tmarri@apm.com>
In-Reply-To: <1285279906-16819-1-git-send-email-tmarri@apm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"herbert@gondor.hengli.com.au" <herbert@gondor.hengli.com.au>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"yur@emcraft.com" <yur@emcraft.com>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On 9/23/2010 3:11 PM, tmarri@apm.com wrote:
> From: Tirumala Marri<tmarri@apm.com>
>
> This patch creates new file with SoC dependent functions.
>
> Signed-off-by: Tirumala R Marri<tmarri@apm.com>
> ---
> V1:
>    * Remove all 440SPe specific references.

Maybe it renames ppc440spe to ppc4xx but it adds things like...

> +#if defined(CONFIG_440SPe) || defined(CONFIG_440SP)
> +               np = of_find_compatible_node(NULL, NULL, "ibm,i2o-440spe");
> +#endif

...in the code.  Which is 1) not generic and 2) I suspect causes a 
compile warning for using an uninitialized variable.

> +               if (!np) {
> +                       pr_err("%s: can't find I2O device tree node\n",
> +                              __func__);
> +                       ret = -ENODEV;
> +                       goto err_req2;
> +               }

It looks to me like the common code will need to have a few build 
dependent helper routines as it appears one instance of the driver 
cannot simultaneously support 440sp, 440spe, and 460ex.

--
Dan