From: Ilya Yanok <yanok@emcraft.com>
To: Wolfgang Denk <wd@denx.de>
Cc: vlad@emcraft.com, linuxppc-dev@lists.ozlabs.org,
Piotr Ziecik <kosmo@semihalf.com>,
dzu@denx.de
Subject: Re: [PATCH 3/3] mpc512x_dma: add MPC8308 support
Date: Tue, 28 Sep 2010 17:47:15 +0400 [thread overview]
Message-ID: <4CA1F1E3.3000809@emcraft.com> (raw)
In-Reply-To: <20100928130919.1558AD5218F@gemini.denx.de>
Dear Wolfgang,
28.09.2010 17:09, Wolfgang Denk wrote:
>> config MPC512X_DMA
>> tristate "Freescale MPC512x built-in DMA engine support"
>> - depends on PPC_MPC512x
>> + depends on PPC_MPC512x || PPC_MPC831x
>
> Is MPC831x correct here? My understanding is that MPC831x processors
> have yet other DMA cotnrollers, and we're on a MPC8308 here?
Well, PPC_MPC831x is not correct here in the strict sense, but there are
some reasons for it:
1. We don't really have PPC_MPC8308 config option for MPC8308
processor. Well, maybe that was my fault that I didn't add it when I
initially introduced support for MPC8308. But I don't actually see the
point for it. All the differencies from MPC831x are handled run-time
based on device-tree.
2. Some of MPC831x (I believe it's MPC8315) really has the compatible
DMA controller (it's called something like DMA controller of the TDM
module). Well it will probably need some additional work in the driver
to support this controller but hardware is mostly the same.
3. Well, it's only compilation option you need a proper device-tree
node for the driver to start. Ok, you can make your kernel bigger by
compiling in the driver which is useless for your CPU but you can't
break it provided you have a correct device-tree.
Regards, Ilya.
next prev parent reply other threads:[~2010-09-28 15:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 12:24 [RFC][PATCH 0/3] fixes and MPC8308 support for the mpc512x_dma driver Ilya Yanok
2010-09-28 12:24 ` [PATCH 1/3] mpc512x_dma: scatter/gather fix Ilya Yanok
2010-09-28 12:24 ` [PATCH 2/3] mpc512x_dma: fix the hanged transfer issue Ilya Yanok
2010-09-28 12:24 ` [PATCH 3/3] mpc512x_dma: add MPC8308 support Ilya Yanok
2010-09-28 13:09 ` Wolfgang Denk
2010-09-28 13:47 ` Ilya Yanok [this message]
2010-10-26 23:52 ` [REPOST] [PATCH 0/6] fixes and MPC8308 support for the mpc512x_dma driver Ilya Yanok
2010-10-27 7:24 ` Piotr Zięcik
2010-10-28 0:44 ` Ilya Yanok
2010-11-11 12:11 ` Wolfgang Denk
2010-10-26 23:52 ` [PATCH 1/6] mpc512x_dma: scatter/gather fix Ilya Yanok
2010-12-30 5:35 ` Grant Likely
2010-10-26 23:52 ` [PATCH 2/6] mpc512x_dma: fix the hanged transfer issue Ilya Yanok
2010-12-30 5:36 ` Grant Likely
2010-10-26 23:52 ` [PATCH 3/6] mpc512x_dma: add MPC8308 support Ilya Yanok
2010-12-30 5:35 ` Grant Likely
2010-10-26 23:52 ` [PATCH 4/6] mpc512x_dma: try to free descriptors in case of allocation failure Ilya Yanok
2010-12-30 5:36 ` Grant Likely
2010-10-26 23:52 ` [PATCH 5/6] MPC8308RDB: add DMA controller device-tree node Ilya Yanok
2010-12-30 5:36 ` Grant Likely
2010-10-26 23:53 ` [PATCH 6/6] mpc8308_p1m: " Ilya Yanok
2010-12-30 5:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA1F1E3.3000809@emcraft.com \
--to=yanok@emcraft.com \
--cc=dzu@denx.de \
--cc=kosmo@semihalf.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vlad@emcraft.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).