From: Heiko Schocher <hs@denx.de>
To: linuxppc-dev@ozlabs.org
Cc: netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Holger Brunck <holger.brunck@keymile.com>,
Detlev Zundel <dzu@denx.de>
Subject: powerpc, fs_enet: scanning PHY after Linux is up
Date: Mon, 04 Oct 2010 09:32:26 +0200 [thread overview]
Message-ID: <4CA9830A.2030605@denx.de> (raw)
Hello all,
we have on the mgcoge arch/powerpc/boot/dts/mgcoge.dts 3 fs_enet
devices. The first is accessible on boot, and so get correct
probed and works fine. For the other two fs_enet devices the PHYs
are on startup in reset, and gets later, through userapplikations,
out of reset ... so, on bootup, this 2 fs_enet devices could
not detect the PHY in drivers/of/of_mdio.c of_mdiobus_register(),
and if we want to use them later, we get for example:
-bash-3.2# ifconfig eth2 172.31.31.33
net eth2: Could not attach to PHY
SIOCSIFFLAGS: No such device
So the problem is, that we cannot rescan the PHYs, if they are
accessible. Also we could not load the fs_enet driver as a module,
because the first port is used fix.
So, first question which comes in my mind, is:
Is detecting the phy in drivers/of/of_mdio.c of_mdiobus_register()
the right place, or should it not better be done, when really
using the port?
But we found another way to solve this issue:
After the PHYs are out of reset, we just have to rescan the PHYs
with (for example PHY with addr 1)
err = mdiobus_scan(bus, 1);
and
of_find_node_by_path("/soc@f0000000/cpm@119c0/mdio@10d40/ethernet-phy@1");
of_node_get(np);
dev_archdata_set_node(&err->dev.archdata, np);
but thats just a hack ...
So, the question is, is there a possibility to solve this problem?
If there is no standard option, what would be with adding a
"scan_phy" file in
/proc/device-tree/soc\@f0000000/cpm\@119c0/mdio\@10d40
(or better destination?)
which with we could rescan a PHY with
"echo addr > /proc/device-tree/soc\@f0000000/cpm\@119c0/mdio\@10d40/scan_phy"
(so there is no need for using of_find_node_by_path(), as we should
have the associated device node here, and can step through the child
nodes with "for_each_child_of_node(np, child)" and check if reg == addr)
or shouldn;t be at least, if the phy couldn;t be found when opening
the port, retrigger a scanning, if the phy now is accessible?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next reply other threads:[~2010-10-04 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 7:32 Heiko Schocher [this message]
2010-10-04 16:20 ` powerpc, fs_enet: scanning PHY after Linux is up Grant Likely
2010-10-06 9:53 ` Heiko Schocher
2010-10-06 16:52 ` Grant Likely
2010-10-08 8:50 ` Holger brunck
2010-10-08 17:06 ` Grant Likely
2010-10-11 11:49 ` Holger brunck
[not found] ` <4CAC7EB0.6080502@keymile.com>
2010-10-06 17:30 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9830A.2030605@denx.de \
--to=hs@denx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dzu@denx.de \
--cc=holger.brunck@keymile.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).