* Powerpc compile error with 2.6.39-rc3 and non-SMP configs
@ 2011-04-13 10:17 Michael Guntsche
2011-04-13 15:45 ` Paul Gortmaker
0 siblings, 1 reply; 2+ messages in thread
From: Michael Guntsche @ 2011-04-13 10:17 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linuxppc-dev
Hi,
Commit b987812b3fc "powerpc/kexec: Fix mismatched ifdefs for PPC64/SMP."
breaks compilation on non SMP powerpc machines.
I wonder if this commit is really neccessary in the first place. The
function definition itself is already between an
#ifdef CONFIG_SMP (line 56)
#endif
block so only exists if SMP=y and PPC_STD_MMU_64=y.
Furthermore the stub in your patch is only created if SMP=y and
PPC_STD_MMU_64=n which breaks non-SMP configs.
Kind regards,
Michael Guntsche
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Powerpc compile error with 2.6.39-rc3 and non-SMP configs
2011-04-13 10:17 Powerpc compile error with 2.6.39-rc3 and non-SMP configs Michael Guntsche
@ 2011-04-13 15:45 ` Paul Gortmaker
0 siblings, 0 replies; 2+ messages in thread
From: Paul Gortmaker @ 2011-04-13 15:45 UTC (permalink / raw)
To: Michael Guntsche; +Cc: linuxppc-dev
On 11-04-13 06:17 AM, Michael Guntsche wrote:
> Hi,
>
> Commit b987812b3fc "powerpc/kexec: Fix mismatched ifdefs for PPC64/SMP."
> breaks compilation on non SMP powerpc machines.
Ah crap. I compile tested on SMP, so didn't see that.
> I wonder if this commit is really neccessary in the first place. The
> function definition itself is already between an
Your analysis is right, but I think getting rid of the #ifdefs is
still the right approach where possible. I'll send a fix shortly.
Thanks for the report.
P.
>
> #ifdef CONFIG_SMP (line 56)
> #endif
>
> block so only exists if SMP=y and PPC_STD_MMU_64=y.
> Furthermore the stub in your patch is only created if SMP=y and
> PPC_STD_MMU_64=n which breaks non-SMP configs.
>
> Kind regards,
> Michael Guntsche
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-13 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-13 10:17 Powerpc compile error with 2.6.39-rc3 and non-SMP configs Michael Guntsche
2011-04-13 15:45 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).