From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Shaun Ruffell <sruffell@digium.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: Define 'crash_kexec_wait_realmode' for Non-SMP systems.
Date: Thu, 14 Apr 2011 19:59:00 -0400 [thread overview]
Message-ID: <4DA78A44.1000704@windriver.com> (raw)
In-Reply-To: <20110414222719.GA16256@digium.com>
On 11-04-14 06:27 PM, Shaun Ruffell wrote:
> This fixes a regression from b987812b3fcaf70fdf0037589e5d2f5f2453e6ce
A fix was already sent yesterday:
http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-April/089559.html
which relocates the stub function to where it needs to be. Your fix
below would end up making duplicate stub functions.
Thanks,
Paul.
> "powerpc/kexec: Fix mismatched ifdefs for PPC64/SMP" which resulted in
>
> arch/powerpc/kernel/crash.c: In function ‘default_machine_crash_shutdown’:
> arch/powerpc/kernel/crash.c:349: error: implicit declaration of function
> ‘crash_kexec_wait_realmode’
>
> message on when compiling on Blue&White G3 and CONFIG_SMP is not defined.
>
> Signed-off-by: Shaun Ruffell <sruffell@digium.com>
> ---
> arch/powerpc/kernel/crash.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> index 3d3d416..5e6e37f 100644
> --- a/arch/powerpc/kernel/crash.c
> +++ b/arch/powerpc/kernel/crash.c
> @@ -255,6 +255,9 @@ void crash_kexec_secondary(struct pt_regs *regs)
> {
> cpus_in_sr = CPU_MASK_NONE;
> }
> +
> +static inline void crash_kexec_wait_realmode(int cpu) {}
> +
> #endif
>
> /*
next prev parent reply other threads:[~2011-04-14 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 22:27 [PATCH] powerpc: Define 'crash_kexec_wait_realmode' for Non-SMP systems Shaun Ruffell
2011-04-14 23:59 ` Paul Gortmaker [this message]
2011-04-15 3:45 ` Shaun Ruffell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA78A44.1000704@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sruffell@digium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).