From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM1EHSOBE005.bigfish.com (am1ehsobe005.messaging.microsoft.com [213.199.154.208]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Cybertrust SureServer Standard Validation CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 4B186B718C for ; Fri, 20 May 2011 02:32:03 +1000 (EST) Message-ID: <4DD545E4.9090408@freescale.com> Date: Thu, 19 May 2011 11:31:32 -0500 From: Timur Tabi MIME-Version: 1.0 To: Alan Cox Subject: Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver References: <1305813272-31826-1-git-send-email-timur@freescale.com> <1305813272-31826-7-git-send-email-timur@freescale.com> <20110519153358.5876f310@lxorguk.ukuu.org.uk> In-Reply-To: <20110519153358.5876f310@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Cc: kumar.gala@freescale.com, linux-kernel@vger.kernel.org, akpm@kernel.org, linux-console@vger.kernel.org, greg@kroah.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Alan Cox wrote: > You really also need a hangup method so vhangup() does the right thing > and you can securely do logins etc and sessions on your console. As > you've got no hardware entangled in this and you already use tty_port > helpers the hangup helper will do the work for you. So all I need is this? static void ehv_bc_tty_hangup(struct tty_struct *ttys) { struct ehv_bc_data *bc = ttys->driver_data; tty_port_hangup(&bc->port); } I've noticed that some drivers flush their transmit buffers before calling tty_port_hangup(), but some others don't. Should I do this too? I don't know if hangup should be as quick as possible. -- Timur Tabi Linux kernel developer at Freescale