From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcsinet10.oracle.com (rcsinet10.oracle.com [148.87.113.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "rcsinet10.oracle.com", Issuer "VeriSign Class 3 International Server CA - G3" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id A2CE9B6FEB for ; Fri, 10 Jun 2011 02:33:04 +1000 (EST) Message-ID: <4DF0F5A1.5080008@oracle.com> Date: Thu, 09 Jun 2011 09:32:33 -0700 From: Randy Dunlap MIME-Version: 1.0 To: Arnd Bergmann Subject: Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver References: <1307573154-15838-1-git-send-email-timur@freescale.com> <20110608161009.7b05d305.randy.dunlap@oracle.com> <201106090938.23027.arnd@arndb.de> In-Reply-To: <201106090938.23027.arnd@arndb.de> Content-Type: text/plain; charset=ISO-8859-1 Cc: konrad.wilk@oracle.com, greg@kroah.com, kumar.gala@freescale.com, linux-kernel@vger.kernel.org, cmetcalf@tilera.com, Linux Virtualization , dsaxena@linaro.org, linux-console@vger.kernel.org, akpm@kernel.org, linuxppc-dev@lists.ozlabs.org, Timur Tabi , alan@lxorguk.ukuu.org.uk List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/09/11 00:38, Arnd Bergmann wrote: > On Thursday 09 June 2011 01:10:09 Randy Dunlap wrote: >> On Wed, 8 Jun 2011 17:45:54 -0500 Timur Tabi wrote: >> >>> Add the drivers/virt directory, which houses drivers that support >>> virtualization environments, and add the Freescale hypervisor management >>> driver. >> >> It can't go in linux/virt or linux/virt/fsl instead? why drivers/ ? >> >> or maybe linux/virt should be drivers/virt ? > > See discussion for v2 of this patch. I suggested that drivers/firmware and virt/ > as options, the counterarguments were that drivers/firmware is for passive > firmware as opposed to firmware that acts as a hypervisor, and that virt/ is > for the host side of hypervisors like kvm, not for guests. OK, I read that thread. Didn't see a real consensus there. If you were not the drivers/misc/ maintainer, would you mind if this driver lived in drivers/misc/? I wouldn't. But it sounds like virt/ needs virt/host/ and virt/guest/ to me. > The driver in here most closely resembles the xen dom0 model, where a > priviledged guest controls other guests, but unlike xen there is a single > driver file, so there is no need to have drivers/fsl-hv directory just > for this one file. We do have a number of other hypervisors that fit in the > same category, so they can be added here later. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***