From: Timur Tabi <timur@freescale.com>
To: Priyanka Jain <Priyanka.Jain@freescale.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
p_gortmaker@yahoo.com, galak@gate.crashing.org,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH][v2] Add support for RTC device: pt7c4338 in rtc-ds1307.c
Date: Wed, 15 Jun 2011 10:05:28 -0500 [thread overview]
Message-ID: <4DF8CA38.4010802@freescale.com> (raw)
In-Reply-To: <1308128390-23347-1-git-send-email-Priyanka.Jain@freescale.com>
Priyanka Jain wrote:
> config RTC_DRV_DS1307
> - tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025"
> + tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025, PT7C4338"
> help
> If you say yes here you get support for various compatible RTC
> chips (often with battery backup) connected with I2C. This driver
> should handle DS1307, DS1337, DS1338, DS1339, DS1340, ST M41T00,
> - EPSON RX-8025 and probably other chips. In some cases the RTC
> - must already have been initialized (by manufacturing or a
> + EPSON RX-8025, PT7C4338 and probably other chips. In some cases
> + the RTC must already have been initialized (by manufacturing or a
> bootloader).
I think you should probably drop the Kconfig change, too. It already says, "and
probably other chips", and you're also just bloating the summary line. We can't
list every possible Dallas-compatible RTC chip here.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2011-06-15 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 8:59 [PATCH][v2] Add support for RTC device: pt7c4338 in rtc-ds1307.c Priyanka Jain
2011-06-15 11:44 ` Tabi Timur-B04825
2011-06-15 15:05 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8CA38.4010802@freescale.com \
--to=timur@freescale.com \
--cc=Priyanka.Jain@freescale.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=galak@gate.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).