From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by ozlabs.org (Postfix) with ESMTP id A40A0B6F62 for ; Sun, 3 Jul 2011 19:12:23 +1000 (EST) Message-ID: <4E103270.4040506@redhat.com> Date: Sun, 03 Jul 2011 12:12:16 +0300 From: Avi Kivity MIME-Version: 1.0 To: Alexander Graf Subject: Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate References: <20110629101552.GA25406@bloggs.ozlabs.ibm.com> <20110629104103.GR25406@bloggs.ozlabs.ibm.com> <4E0C9077.2060608@suse.de> <4E0C9339.2080601@redhat.com> <4E0C94A0.3090301@suse.de> <4E0C9D98.5000904@redhat.com> <2EDDAC02-4BDC-4007-82E1-2C6D732C24D5@suse.de> <4E102516.1040805@redhat.com> <70A08140-B592-4B2F-985B-D8E5C78C743B@suse.de> <4E102ECE.1060004@redhat.com> <4E1030E1.6070101@redhat.com> <77E6DEE3-F00A-46EA-B8AF-58BC62A8143D@suse.de> In-Reply-To: <77E6DEE3-F00A-46EA-B8AF-58BC62A8143D@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Scott Wood , "linuxppc-dev@ozlabs.org" , Paul Mackerras , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/03/2011 12:09 PM, Alexander Graf wrote: > > > > Right. The idea is that if KVM_FLAG_BLAH implies a field kvm_struct::blah, then either both are present in the headers, or none of them. > > Yup, makes sense. I like the idea :). Gets rid of all the useless paddings and reserved fields. We could even truncate the structs that already have paddings in them if we only copy min(sizeof(real_struct), ioctl_passed_size); (which we should anyways). > No, we can't change anything that is already out. If will change the ioctl numbers, so building against new headers but running against an old kernel will fail. > How long until we get a patch set? :) Well, I'd really like to get the qemu memory API out first. -- error compiling committee.c: too many arguments to function