From: Tabi Timur-B04825 <B04825@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Anton Blanchard <anton@samba.org>
Subject: Re: hvc_console change results in corrupt oops output
Date: Tue, 5 Jul 2011 13:51:09 +0000 [thread overview]
Message-ID: <4E1316CC.9090000@freescale.com> (raw)
In-Reply-To: <1309846963.14501.270.camel@pasglop>
Benjamin Herrenschmidt wrote:
> That is a fun conclusion considering that hvc has been written for the
> pseries hypervisor which ... can return BUSY on writes :-)
Go read the original thread. The problem is that tty writes and console=20
writes are treated the same by the hvc client driver. If a client driver=20
detects that the hypervisor is busy, it has the choice of either spinning=20
or returning right away. Spinning is not acceptable for tty output, so=20
all drivers return right away. hvc then drops the unwritten characters.
According to Hendrik, this is still happening.
> We just need to fix HVC properly.
Where were you two years ago? I complained about the problem, and even=20
posted a hackish "fix". The response I got was tepid -- some=20
acknowledgement that the problem exists, but no real desire to fix it by=20
anyone.
So I had no choice but to abandon hvc. And frankly, I still don't=20
understand why it exists. Since then, I wrote a very nice console/tty=20
driver, and I have no plans to return to hvc even if the problem is fixed.
--=20
Timur Tabi
Linux kernel developer at Freescale=
next prev parent reply other threads:[~2011-07-05 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 10:57 hvc_console change results in corrupt oops output Anton Blanchard
2011-07-04 13:56 ` Benjamin Herrenschmidt
2011-07-04 14:24 ` Hendrik Brueckner
2011-07-05 4:17 ` Tabi Timur-B04825
2011-07-05 6:22 ` Benjamin Herrenschmidt
2011-07-05 13:51 ` Tabi Timur-B04825 [this message]
2011-07-05 14:28 ` [RFC] [PATCH] hvc_console: improve tty/console put_chars handling Hendrik Brueckner
2011-07-06 7:49 ` Anton Blanchard
2011-07-06 7:50 ` [PATCH 1/2]: " Anton Blanchard
2011-07-06 7:51 ` [PATCH 2/2]: powerpc/pseries/hvconsole: Fix dropped console output Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1316CC.9090000@freescale.com \
--to=b04825@freescale.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).