From: Matt Evans <matt@ozlabs.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
eric.dumazet@gmail.com
Subject: Re: [PATCH] net: filter: BPF 'JIT' compiler for PPC64
Date: Tue, 19 Jul 2011 11:21:28 +1000 [thread overview]
Message-ID: <4E24DC18.7050007@ozlabs.org> (raw)
In-Reply-To: <20110718.124248.1462465498024218250.davem@davemloft.net>
On 19/07/11 05:42, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 18 Jul 2011 10:39:35 +0200
>
>> So in PPC SEEN_XREG only is to be set of X is read, not if written.
>>
>> So you dont have to set SEEN_XREG bit in this part :
>
> Matt, do you want to integrate changes based upon Eric's feedback
> here or do you want me to apply your patch as-is for now?
Thanks, but no worries; I will send a v2 in a sec. Eric's comments are spot-on,
and there are a couple of other areas that the brainfart should really be
polished out of, too. :-)
Cheers,
Matt
next prev parent reply other threads:[~2011-07-19 1:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 7:50 [PATCH] net: filter: BPF 'JIT' compiler for PPC64 Matt Evans
2011-07-18 8:39 ` Eric Dumazet
2011-07-18 19:42 ` David Miller
2011-07-18 20:05 ` Eric Dumazet
2011-07-19 1:21 ` Matt Evans [this message]
2011-07-19 2:13 ` [PATCH v2] " Matt Evans
2011-07-19 6:51 ` Eric Dumazet
2011-07-19 7:55 ` Benjamin Herrenschmidt
2011-07-19 9:06 ` Eric Dumazet
2011-07-19 9:22 ` Benjamin Herrenschmidt
2011-07-19 6:59 ` Kumar Gala
2011-07-19 7:06 ` Matt Evans
2011-07-19 7:17 ` Kumar Gala
2011-07-19 7:23 ` Matt Evans
2011-07-21 1:51 ` [PATCH v3] " Matt Evans
2011-07-21 5:00 ` Eric Dumazet
2011-07-21 19:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E24DC18.7050007@ozlabs.org \
--to=matt@ozlabs.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).