From: Matt Evans <matt@ozlabs.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] net: filter: BPF 'JIT' compiler for PPC64
Date: Tue, 19 Jul 2011 17:23:36 +1000 [thread overview]
Message-ID: <4E2530F8.2000609@ozlabs.org> (raw)
In-Reply-To: <CBA05A49-86F1-40FF-9244-0E4D29EBBA48@kernel.crashing.org>
On 19/07/11 17:17, Kumar Gala wrote:
>
> On Jul 19, 2011, at 2:06 AM, Matt Evans wrote:
>
>> On 19/07/11 16:59, Kumar Gala wrote:
>>>
>>> On Jul 18, 2011, at 9:13 PM, Matt Evans wrote:
>>>
>>>> [snip]
>>>>
>>>> V2: Removed some cut/paste woe in setting SEEN_X even on writes.
>>>> Merci for le review, Eric!
>>>>
>>>> arch/powerpc/Kconfig | 1 +
>>>> arch/powerpc/Makefile | 3 +-
>>>> arch/powerpc/include/asm/ppc-opcode.h | 40 ++
>>>> arch/powerpc/net/Makefile | 4 +
>>>> arch/powerpc/net/bpf_jit.S | 138 +++++++
>>>
>>> can we rename to bpf_jit_64.S, since this doesn't work on PPC32.
>>>
>>>> arch/powerpc/net/bpf_jit.h | 227 +++++++++++
>>>> arch/powerpc/net/bpf_jit_comp.c | 690 +++++++++++++++++++++++++++++++++
>>>
>>> same here, or split between bpf_jit_comp.c (shared between ppc32 & ppc64) and
>>> bpf_jit_comp_64.c
>>
>> A reasonable suggestion -- bpf_jit_64.S certainly. I think it may not be worth
>> splitting bpf_jit_comp.c until we support both tho? (I'm thinking
>> bpf_jit_comp_{32,64}.c would just house the stackframe generation code which is
>> the main difference, plus compile-time switched macros for the odd LD vs LWZ.)
>
> If its most 64-bit specific than just go with bpf_jit_comp_64.c for now. We can refactor later.
Nah, other way round -- it's almost all agnostic but with a couple of functions
that I was recommending moving out to a _64.c and _32.c later, leaving the bulk
still in bpf_jit_comp.c.
Matt
next prev parent reply other threads:[~2011-07-19 7:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 7:50 [PATCH] net: filter: BPF 'JIT' compiler for PPC64 Matt Evans
2011-07-18 8:39 ` Eric Dumazet
2011-07-18 19:42 ` David Miller
2011-07-18 20:05 ` Eric Dumazet
2011-07-19 1:21 ` Matt Evans
2011-07-19 2:13 ` [PATCH v2] " Matt Evans
2011-07-19 6:51 ` Eric Dumazet
2011-07-19 7:55 ` Benjamin Herrenschmidt
2011-07-19 9:06 ` Eric Dumazet
2011-07-19 9:22 ` Benjamin Herrenschmidt
2011-07-19 6:59 ` Kumar Gala
2011-07-19 7:06 ` Matt Evans
2011-07-19 7:17 ` Kumar Gala
2011-07-19 7:23 ` Matt Evans [this message]
2011-07-21 1:51 ` [PATCH v3] " Matt Evans
2011-07-21 5:00 ` Eric Dumazet
2011-07-21 19:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2530F8.2000609@ozlabs.org \
--to=matt@ozlabs.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).