From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4E42B83C.2040705@freescale.com> Date: Wed, 10 Aug 2011 11:56:28 -0500 From: Scott Wood MIME-Version: 1.0 To: Robin Holt Subject: Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding. References: <1312993670-23999-1-git-send-email-holt@sgi.com> <1312993670-23999-6-git-send-email-holt@sgi.com> In-Reply-To: <1312993670-23999-6-git-send-email-holt@sgi.com> Content-Type: text/plain; charset="UTF-8" Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, U Bhaskar-B22300 , PPC list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/10/2011 11:27 AM, Robin Holt wrote: > -CPI Clock- Can Protocol Interface Clock > - This CLK_SRC bit of CTRL(control register) selects the clock source to > - the CAN Protocol Interface(CPI) to be either the peripheral clock > - (driven by the PLL) or the crystal oscillator clock. The selected clock > - is the one fed to the prescaler to generate the Serial Clock (Sclock). > - The PRESDIV field of CTRL(control register) controls a prescaler that > - generates the Serial Clock (Sclock), whose period defines the > - time quantum used to compose the CAN waveform. > +- compatible : Should be "fsl,flexcan" and optionally > + "fsl,flexcan-" fsl,-flexcan, and it should not be optional, and should come before "fsl,flexcan". Also may want to list fsl,p1010-rdb as a "canonical compatible" for anything which is backwards compatible with p1010's implementation. -Scott