From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Robin Holt <holt@sgi.com>
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
U Bhaskar-B22300 <B22300@freescale.com>,
Scott Wood <scottwood@freescale.com>,
PPC list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding.
Date: Mon, 15 Aug 2011 18:13:45 +0200 [thread overview]
Message-ID: <4E4945B9.2020201@pengutronix.de> (raw)
In-Reply-To: <20110815150357.GM4926@sgi.com>
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
On 08/15/2011 05:03 PM, Robin Holt wrote:
> Earlier, you had asked for a more specific name for the compatible
> property of the Freescale flexcan device. I still have not gotten a
> more specific answer. Hopefully Marc can give you more details about
> the flexcan implementations.
There are at least 2 versions of the flexcan ip core in the wild. Due to
lack of version numbers or other names I call them old and new here :).
The newer one supports rx fifo mode, whereas the older one doesn't. The
mainline flexcan driver just supports the new core [1]. The older core
is found on coldfire processors. I don't know if there are coldfire cpus
with the new flexcan core, too. The driver can be adopted to the old
core if needed.
The first cpus with the new core I got in touch with was the mx35
(arm11) and mx25 (arm9) both at the same time. Ask fsl which one was
released first. After this there was mx28 (arm9) and there should be an
mx53 (coretexa8) with flexcan too.
> Other than an agreement on the compatible property, I believe we have
> agreement on all the other code changes in these patches. Is this change
> acceptable as is and if we get a better resolution on the fsl,flexcan
> name later, we can update the documentation and driver then?
cheers, Marc
[1] http://lxr.linux.no/linux+v3.0.1/drivers/net/can/flexcan.c#L871
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-08-15 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 8:45 [PATCH v12 0/6] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010) Robin Holt
2011-08-12 8:45 ` [PATCH v12 1/6] flexcan: Remove #include <mach/clock.h> Robin Holt
2011-08-12 8:45 ` [PATCH v12 2/6] flexcan: Abstract off read/write for big/little endian Robin Holt
2011-08-12 8:45 ` [PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding Robin Holt
2011-08-15 15:03 ` Robin Holt
2011-08-15 15:13 ` Grant Likely
2011-08-15 15:25 ` Robin Holt
2011-08-15 16:13 ` Marc Kleine-Budde [this message]
2011-08-12 8:45 ` [PATCH v12 4/6] flexcan: Add of_match to platform_device definition Robin Holt
2011-08-12 8:45 ` [PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available Robin Holt
2011-08-12 12:22 ` Wolfgang Grandegger
2011-08-12 8:45 ` [PATCH v12 6/6] powerpc: Add flexcan device support for p1010rdb Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4945B9.2020201@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=B22300@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=holt@sgi.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).