* [PATCH] powerpc: fixup QE_General4 errata
@ 2011-08-23 12:30 Joakim Tjernlund
2011-08-23 17:48 ` Timur Tabi
2011-11-24 7:45 ` Kumar Gala
0 siblings, 2 replies; 3+ messages in thread
From: Joakim Tjernlund @ 2011-08-23 12:30 UTC (permalink / raw)
To: Timur Tabi, linuxppc-dev
QE_General4 should only round up the divisor iff divisor is > 3.
Rounding up lower divisors makes the error too big, causing USB
on MPC832x to fail.
Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
arch/powerpc/sysdev/qe_lib/qe.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
index 093e0ae..5399316 100644
--- a/arch/powerpc/sysdev/qe_lib/qe.c
+++ b/arch/powerpc/sysdev/qe_lib/qe.c
@@ -216,7 +216,7 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, unsigned int multiplier)
/* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says
that the BRG divisor must be even if you're not using divide-by-16
mode. */
- if (!div16 && (divisor & 1))
+ if (!div16 && (divisor & 1) && (divisor > 3))
divisor++;
tempval = ((divisor - 1) << QE_BRGC_DIVISOR_SHIFT) |
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: fixup QE_General4 errata
2011-08-23 12:30 [PATCH] powerpc: fixup QE_General4 errata Joakim Tjernlund
@ 2011-08-23 17:48 ` Timur Tabi
2011-11-24 7:45 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Timur Tabi @ 2011-08-23 17:48 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: Kumar Gala, linuxppc-dev
Joakim Tjernlund wrote:
> QE_General4 should only round up the divisor iff divisor is > 3.
> Rounding up lower divisors makes the error too big, causing USB
> on MPC832x to fail.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Acked-by: Timur Tabi <timur@freescale.com>
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: fixup QE_General4 errata
2011-08-23 12:30 [PATCH] powerpc: fixup QE_General4 errata Joakim Tjernlund
2011-08-23 17:48 ` Timur Tabi
@ 2011-11-24 7:45 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2011-11-24 7:45 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: linuxppc-dev, Timur Tabi
On Aug 23, 2011, at 7:30 AM, Joakim Tjernlund wrote:
> QE_General4 should only round up the divisor iff divisor is > 3.
> Rounding up lower divisors makes the error too big, causing USB
> on MPC832x to fail.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> arch/powerpc/sysdev/qe_lib/qe.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied to merge
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-24 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-23 12:30 [PATCH] powerpc: fixup QE_General4 errata Joakim Tjernlund
2011-08-23 17:48 ` Timur Tabi
2011-11-24 7:45 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).