From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Anatolij Gustschin <agust@denx.de>,
Tabi Timur-B04825 <B04825@freescale.com>
Subject: Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS
Date: Mon, 26 Sep 2011 17:24:43 -0500 [thread overview]
Message-ID: <4E80FBAB.7080706@freescale.com> (raw)
In-Reply-To: <FAF4E48A-0966-4A6E-8D31-B30D07CB0746@kernel.crashing.org>
On 09/26/2011 05:12 PM, Kumar Gala wrote:
>
> On Sep 25, 2011, at 12:06 PM, Tabi Timur-B04825 wrote:
>
>> On Fri, Sep 23, 2011 at 2:32 PM, Anatolij Gustschin <agust@denx.de> wrote:
>>
>>> diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
>>> index 1b393f4..b29d4f2 100644
>>> --- a/arch/powerpc/platforms/85xx/Kconfig
>>> +++ b/arch/powerpc/platforms/85xx/Kconfig
>>> @@ -80,7 +80,7 @@ config P1010_RDB
>>> config P1022_DS
>>> bool "Freescale P1022 DS"
>>> select DEFAULT_UIMAGE
>>> - select CONFIG_PHYS_64BIT # The DTS has 36-bit addresses
>>> + select PHYS_64BIT # The DTS has 36-bit addresses
>>
>> I have no idea how this happened, but I wonder if it's a good idea.
>> On the Freescale BSP, the default config for the P1022DS is 32-bit,
>> not 36-bit, so one day we might have a 32-bit config in the upstream
>> repository.
>>
>> PHYS_64BIT is already covered by the defconfig. I wonder if we should
>> just delete the bad line, and let the defconfig select the address
>> size.
>
> Why, the way this patch makes it will work both with a 32-bit or 36-bit address map. The comment should be fixed since its wrong.
"select" should not be used for things that you think make good
defaults. It should be used for things that are required. It's just
like "depends on", except for user interface considerations (and the
whole transitive dependency mess).
-Scott
next prev parent reply other threads:[~2011-09-26 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 19:32 [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS Anatolij Gustschin
2011-09-25 17:06 ` Tabi Timur-B04825
2011-09-26 22:12 ` Kumar Gala
2011-09-26 22:14 ` Timur Tabi
2011-09-26 22:24 ` Scott Wood [this message]
2011-10-12 4:53 ` Kumar Gala
2011-10-13 14:14 ` Tabi Timur-B04825
2011-10-13 15:31 ` Kumar Gala
2011-10-13 15:35 ` Timur Tabi
2011-10-13 15:41 ` Kumar Gala
2011-10-13 15:45 ` Timur Tabi
2011-10-13 15:52 ` Anatolij Gustschin
2011-10-13 15:50 ` Anatolij Gustschin
2011-10-13 15:59 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E80FBAB.7080706@freescale.com \
--to=scottwood@freescale.com \
--cc=B04825@freescale.com \
--cc=agust@denx.de \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).