From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"hjk@hansjkoch.de" <hjk@hansjkoch.de>,
"gregkh@suse.de" <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiang Kai-B18973 <B18973@freescale.com>
Subject: Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems
Date: Thu, 13 Oct 2011 10:34:17 -0500 [thread overview]
Message-ID: <4E9704F9.1090103@freescale.com> (raw)
In-Reply-To: <9BD33578-CD8E-4784-AC6A-ADE4614E0FC1@kernel.crashing.org>
Kumar Gala wrote:
>>> >> + phys_addr_t addr;
>> >
>> > Please add a comment here saying:
>> >
>> > 1) That 'addr' can be a virtual or physical address
> The code and everything else makes that clear
I'm sorry, but I have to strongly disagree here. It is *NOT* clear that a
variable of type 'phys_addr_t' can hold something that is not a physical address.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-10-13 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 20:57 [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems Kumar Gala
2011-10-13 14:37 ` Tabi Timur-B04825
2011-10-13 15:32 ` Kumar Gala
2011-10-13 15:34 ` Timur Tabi [this message]
2011-10-13 15:37 ` David Laight
2011-10-13 15:41 ` Timur Tabi
2011-10-13 15:50 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9704F9.1090103@freescale.com \
--to=timur@freescale.com \
--cc=B18973@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).