From: Scott Wood <scottwood@freescale.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Michal Simek <monstr@monstr.eu>,
tmarri@apm.com,
Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>,
David Laight <David.Laight@ACULAB.COM>,
Suzuki Poulose <suzuki@in.ibm.com>,
Paul Mackerras <paulus@samba.org>,
linux ppc dev <linuxppc-dev@lists.ozlabs.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 2/3] [44x] Enable CONFIG_RELOCATABLE for PPC44x
Date: Tue, 25 Oct 2011 10:34:25 -0500 [thread overview]
Message-ID: <4EA6D701.3030603@freescale.com> (raw)
In-Reply-To: <1318428902.3782.9.camel@nimitz>
On 10/12/2011 09:15 AM, Dave Hansen wrote:
> On Tue, 2011-10-11 at 18:24 +0530, Suzuki Poulose wrote:
>> On 10/10/11 23:30, Scott Wood wrote:
>>> On 10/10/2011 04:56 AM, Suzuki K. Poulose wrote:
>>>> #if defined(CONFIG_RELOCATABLE)&& defined(CONFIG_44x)
>>>> #define __va(x) ((void *)(unsigned long)((phys_addr_t)(x) - PHYSICAL_START + (KERNELBASE + RELOC_OFFSET)))
>>>> #define __pa(x) ((unsigned long)(x) + PHYSICAL_START - (KERNELBASE + RELOC_OFFSET))
>>>> #endif
>>>
>>> Why is this 44x-specific?
>>
>> As of now, we compile with relocations only for the 44x. We could make this
>> generic once the approach is accepted by everyone and implemented on the other
>> platforms.
>
> This is not the place to enforce that kind of thing. If
> CONFIG_RELOCATABLE is only supported on one platform, then do:
>
> config RELOCATABLE
> depends on 44x
>
> and take the 44x reference out of the #ifdef.
...but please first rename the existing, different CONFIG_RELOCATABLE
behavior that is currently supported on e500.
-Scott
next prev parent reply other threads:[~2011-10-25 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 9:54 [PATCH 0/3] Kdump support for PPC440x Suzuki K. Poulose
2011-10-10 9:55 ` [PATCH 1/3] [powerpc32] Process dynamic relocations for kernel Suzuki K. Poulose
2011-10-10 15:15 ` Scott Wood
2011-10-10 17:17 ` Suzuki Poulose
2011-10-10 17:55 ` Scott Wood
2011-10-10 9:56 ` [PATCH 2/3] [44x] Enable CONFIG_RELOCATABLE for PPC44x Suzuki K. Poulose
2011-10-10 18:00 ` Scott Wood
2011-10-11 12:54 ` Suzuki Poulose
2011-10-12 14:15 ` Dave Hansen
2011-10-25 15:34 ` Scott Wood [this message]
2011-10-26 19:12 ` Suzuki Poulose
2011-10-26 19:16 ` Scott Wood
2011-10-27 8:43 ` Suzuki Poulose
2011-10-27 15:41 ` Scott Wood
2011-10-28 5:03 ` Suzuki Poulose
2011-10-10 9:57 ` [PATCH 3/3] [44x] Enable CRASH_DUMP for 440x Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA6D701.3030603@freescale.com \
--to=scottwood@freescale.com \
--cc=David.Laight@ACULAB.COM \
--cc=dave@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=monstr@monstr.eu \
--cc=paulus@samba.org \
--cc=suzuki@in.ibm.com \
--cc=tmarri@apm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).