From: Rusev <arusev@dev.rtsoft.ru>
To: benh@kernel.crashing.org, paulus@samba.org,
galak@kernel.crashing.org, Shengzhou.Liu@freescale.com,
Shaohui.Xie@freescale.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Fix for fsl_upm
Date: Thu, 27 Oct 2011 18:18:37 +0400 [thread overview]
Message-ID: <4EA9683D.8030100@dev.rtsoft.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 46 bytes --]
patch is vs. 2.6.39, yet it applied to 3.1
[-- Attachment #2: fsl_lbc.c.patch --]
[-- Type: text/x-patch, Size: 694 bytes --]
Fix of UPM driver for Freescale PowerPC processors
If Freescale LBC driver fails to initialise itself from device tree,
then internal structure is freed only but not NULL-fied.
As result functions fsl_lbc_find() after checking the structure is not NULL are
trying to access device registers.
Signed-off-by: Alexandre Rusev <arusev@dev.rtsoft.ru>
--- linux-2.6.39.old/arch/powerpc/sysdev/fsl_lbc.c 2011-10-27 03:17:28.000000000 +0400
+++ linux-2.6.39/arch/powerpc/sysdev/fsl_lbc.c 2011-10-27 05:06:44.000000000 +0400
@@ -322,6 +322,7 @@ static int __devinit fsl_lbc_ctrl_probe(
err:
iounmap(fsl_lbc_ctrl_dev->regs);
kfree(fsl_lbc_ctrl_dev);
+ fsl_lbc_ctrl_dev = NULL;
return ret;
}
next reply other threads:[~2011-10-27 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 14:18 Rusev [this message]
2011-10-27 18:28 ` Fix for fsl_upm Kumar Gala
2011-11-24 7:46 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA9683D.8030100@dev.rtsoft.ru \
--to=arusev@dev.rtsoft.ru \
--cc=Shaohui.Xie@freescale.com \
--cc=Shengzhou.Liu@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).