From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dev.rtsoft.ru (mail.dev.rtsoft.ru [213.79.90.226]) by ozlabs.org (Postfix) with SMTP id 4BE041007DA for ; Fri, 28 Oct 2011 01:25:19 +1100 (EST) Message-ID: <4EA9683D.8030100@dev.rtsoft.ru> Date: Thu, 27 Oct 2011 18:18:37 +0400 From: Rusev MIME-Version: 1.0 To: benh@kernel.crashing.org, paulus@samba.org, galak@kernel.crashing.org, Shengzhou.Liu@freescale.com, Shaohui.Xie@freescale.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Fix for fsl_upm Content-Type: multipart/mixed; boundary="------------090608020905030200050608" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. --------------090608020905030200050608 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit patch is vs. 2.6.39, yet it applied to 3.1 --------------090608020905030200050608 Content-Type: text/x-patch; name="fsl_lbc.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fsl_lbc.c.patch" Fix of UPM driver for Freescale PowerPC processors If Freescale LBC driver fails to initialise itself from device tree, then internal structure is freed only but not NULL-fied. As result functions fsl_lbc_find() after checking the structure is not NULL are trying to access device registers. Signed-off-by: Alexandre Rusev --- linux-2.6.39.old/arch/powerpc/sysdev/fsl_lbc.c 2011-10-27 03:17:28.000000000 +0400 +++ linux-2.6.39/arch/powerpc/sysdev/fsl_lbc.c 2011-10-27 05:06:44.000000000 +0400 @@ -322,6 +322,7 @@ static int __devinit fsl_lbc_ctrl_probe( err: iounmap(fsl_lbc_ctrl_dev->regs); kfree(fsl_lbc_ctrl_dev); + fsl_lbc_ctrl_dev = NULL; return ret; } --------------090608020905030200050608--