From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Liu Gang <Gang.Liu@freescale.com>
Cc: r58472@freescale.com, linux-kernel@vger.kernel.org,
r61911@freescale.com, Alexandre.Bounine@idt.com,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
B11780@freescale.com
Subject: Re: [PATCH] fsl-rio: fix compile error
Date: Fri, 11 Nov 2011 10:48:11 -0500 [thread overview]
Message-ID: <4EBD43BB.8090903@windriver.com> (raw)
In-Reply-To: <1321019308-7785-1-git-send-email-Gang.Liu@freescale.com>
On 11-11-11 08:48 AM, Liu Gang wrote:
> The "#include <linux/module.h>" was replaced by "#include <linux/export.h>"
> in the patch "powerpc: various straight conversions from module.h --> export.h".
> This will cause the following compile problem:
> arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception':
> arch/powerpc/sysdev/fsl_rio.c:296: error: implicit declaration of function 'search_exception_tables'.
>
> The file fsl_rio.c needs the declaration of function "search_exception_tables"
> in the header file "linux/module.h".
Thanks -- not sure why this never showed up in my builds of all the
powerpc configs, _or_ the linux-next builds. Maybe srio isn't enabled
in any of them?
In any case it looks fine to me. Having the search_exception_tables
live in module.h seems odd, but that is an independent issue for later.
I can queue this unless someone else has already done so.
Paul.
>
> Signed-off-by: Liu Gang <Gang.Liu@freescale.com>
> ---
> arch/powerpc/sysdev/fsl_rio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
> index de170fd..22ffccd 100644
> --- a/arch/powerpc/sysdev/fsl_rio.c
> +++ b/arch/powerpc/sysdev/fsl_rio.c
> @@ -23,7 +23,7 @@
> */
>
> #include <linux/init.h>
> -#include <linux/export.h>
> +#include <linux/module.h>
> #include <linux/types.h>
> #include <linux/dma-mapping.h>
> #include <linux/interrupt.h>
next prev parent reply other threads:[~2011-11-11 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 13:48 [PATCH] fsl-rio: fix compile error Liu Gang
2011-11-11 15:48 ` Paul Gortmaker [this message]
2011-11-12 5:42 ` Liu Gang-B34182
2011-11-11 16:49 ` Bounine, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBD43BB.8090903@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=Alexandre.Bounine@idt.com \
--cc=B11780@freescale.com \
--cc=Gang.Liu@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
--cc=r61911@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).