linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Liu Gang <Gang.Liu@freescale.com>
Cc: r58472@freescale.com, Kai Jiang <Kai.Jiang@freescale.com>,
	linux-kernel@vger.kernel.org, r61911@freescale.com,
	Alexandre.Bounine@idt.com, akpm@linux-foundation.org,
	linuxppc-dev@lists.ozlabs.org, B11780@freescale.com
Subject: Re: [PATCH 4/5, v3] powerpc/8xxx: Update device tree bus probe for new RapidIO node binding
Date: Mon, 14 Nov 2011 11:35:01 -0600	[thread overview]
Message-ID: <4EC15145.3030001@freescale.com> (raw)
In-Reply-To: <1321099352-21462-4-git-send-email-Gang.Liu@freescale.com>

On 11/12/2011 06:02 AM, Liu Gang wrote:
> From: Kai Jiang <Kai.Jiang@freescale.com>
> 
> Update of_platform_bus_probe() RapidIO node to be compitable with
> new RapidIO dts compatible property.
> 
> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  arch/powerpc/platforms/85xx/corenet_ds.c   |    2 +-
>  arch/powerpc/platforms/85xx/mpc85xx_mds.c  |    2 +-
>  arch/powerpc/platforms/86xx/mpc86xx_hpcn.c |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c b/arch/powerpc/platforms/85xx/corenet_ds.c
> index 802ad11..c48b661 100644
> --- a/arch/powerpc/platforms/85xx/corenet_ds.c
> +++ b/arch/powerpc/platforms/85xx/corenet_ds.c
> @@ -112,7 +112,7 @@ static const struct of_device_id of_device_ids[] __devinitconst = {
>  		.compatible	= "simple-bus"
>  	},
>  	{
> -		.compatible	= "fsl,rapidio-delta",
> +		.compatible	= "fsl,srio",

fsl,srio is too vague.  We need to identify the specific hardware (or at
least a concrete programming interface document), not just the bus  that
the hardware implements.

-Scott

  reply	other threads:[~2011-11-14 17:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-12 12:02 [PATCH 1/5, v3] fsl-rio: Split rio driver into two parts, RapidIO endpoint and message unit Liu Gang
2011-11-12 12:02 ` [PATCH 2/5, v3] fsl-rio: Add two ports and rapidio message units support Liu Gang
2011-11-16 13:39   ` Bounine, Alexandre
2011-11-16 15:33     ` Kumar Gala
2011-11-12 12:02 ` [PATCH 3/5,v3] powerpc/85xx: Update SRIO device tree nodes Liu Gang
2011-11-16 13:40   ` Bounine, Alexandre
2011-11-16 15:35   ` Kumar Gala
2011-11-12 12:02 ` [PATCH 4/5, v3] powerpc/8xxx: Update device tree bus probe for new RapidIO node binding Liu Gang
2011-11-14 17:35   ` Scott Wood [this message]
2011-11-14 17:37     ` Scott Wood
2011-11-15  3:21       ` Liu Gang-B34182
2011-11-16 13:48   ` Bounine, Alexandre
2011-11-16 15:33     ` Kumar Gala
2011-11-12 12:02 ` [PATCH 5/5, v3] powerpc/fsl: Document rapidio node binding-information Liu Gang
2011-11-16 13:49   ` Bounine, Alexandre
2011-11-16 15:31     ` Kumar Gala
2011-11-16 13:36 ` [PATCH 1/5, v3] fsl-rio: Split rio driver into two parts, RapidIO endpoint and message unit Bounine, Alexandre
2011-11-16 15:33   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC15145.3030001@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Alexandre.Bounine@idt.com \
    --cc=B11780@freescale.com \
    --cc=Gang.Liu@freescale.com \
    --cc=Kai.Jiang@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=r58472@freescale.com \
    --cc=r61911@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).