From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/p1023: set IRQ[4:6, 11] to high level sensitive for PCIe
Date: Tue, 15 Nov 2011 16:14:03 -0600 [thread overview]
Message-ID: <4EC2E42B.1090600@freescale.com> (raw)
In-Reply-To: <45E28F47-CC83-4059-959F-E890049F416B@kernel.crashing.org>
On 11/15/2011 03:51 PM, Kumar Gala wrote:
>
> On Nov 7, 2011, at 2:32 AM, Roy Zang wrote:
>
> Should be setting ALL PCIe interrupts to '2'? As I think in general
> we say these PCIe are 'active high'. The only reason I would think
> we would NOT do this is if they are shared with some external device
> that is 'active low'. If so we should comment that somewhere (maybe
> in the .dts, maybe just in the commit message).
I'd assume the ones that are pinned out are pulled high on the board.
Active-low is normal, it's these non-pinned-out "external" interrupts
that are pulled low inside the SoC that are weird.
-Scott
next prev parent reply other threads:[~2011-11-15 22:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 8:32 [PATCH] powerpc/p1023: set IRQ[4:6, 11] to high level sensitive for PCIe Roy Zang
2011-11-07 18:44 ` Scott Wood
2011-11-08 5:51 ` Zang Roy-R61911
2011-11-08 16:54 ` Scott Wood
2011-11-09 15:27 ` Zang Roy-R61911
2011-11-09 15:38 ` Scott Wood
2011-11-09 15:49 ` Kumar Gala
2011-11-15 21:51 ` Kumar Gala
2011-11-15 22:14 ` Scott Wood [this message]
2011-11-16 4:27 ` Zang Roy-R61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC2E42B.1090600@freescale.com \
--to=scottwood@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).