From: Timur Tabi <timur@freescale.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, kumar.gala@freescale.com
Subject: Re: [PATCH 2/2] powerpc/85xx: p1022ds: enable monitor switching via pixis indirect mode
Date: Mon, 21 Nov 2011 11:01:21 -0600 [thread overview]
Message-ID: <4ECA83E1.6090902@freescale.com> (raw)
In-Reply-To: <20111119120455.8435467a8c11a2a122321670@canb.auug.org.au>
Stephen Rothwell wrote:
> exit_lcs1_iounmap:
> iounmap(lbc_lcs1_ba);
> exit_lcs0_iounmap:
> iounmap(lbc_lcs0_ba);
> exit_indirect_node:
> of_node_put(indirect_node);
> exit_guts_iounmap:
> iounmap(guts);
The point I'm trying to make is that I don't want to have multiple goto exit labels. If I have to rearrange the code or add/delete code, then I probably would need to make similar changes to these labels. I just don't like that sort of thing.
I appreciate your taking the time to review my code and provide suggestions. However, considering that I'm modifying my own code, I would hope that you can appreciate my personal coding style preference. And my style is to reduce the number of labels, even if it means superfluous checks in the exit code.
So Kumar, if there are no further objections, please apply this patch as-is. Thank you.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-11-21 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 18:57 [PATCH 1/2] powerpc/85xx: add pixis indirect mode device tree node Timur Tabi
2011-11-17 18:57 ` [PATCH 2/2] powerpc/85xx: p1022ds: enable monitor switching via pixis indirect mode Timur Tabi
2011-11-17 21:29 ` Stephen Rothwell
2011-11-17 22:09 ` Timur Tabi
2011-11-19 1:04 ` Stephen Rothwell
2011-11-21 17:01 ` Timur Tabi [this message]
2011-11-17 21:37 ` Scott Wood
2011-11-17 22:12 ` Timur Tabi
2011-11-17 22:25 ` Scott Wood
2011-11-17 22:28 ` Timur Tabi
2011-11-17 22:45 ` Scott Wood
2011-11-18 17:00 ` Timur Tabi
2011-11-18 18:06 ` Scott Wood
2011-11-18 18:08 ` Timur Tabi
2011-11-17 21:50 ` [PATCH 1/2] powerpc/85xx: add pixis indirect mode device tree node Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECA83E1.6090902@freescale.com \
--to=timur@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).