From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DDDD1DDDE9 for ; Tue, 3 Jun 2008 09:07:15 +1000 (EST) Message-Id: <4ECB0A32-6194-4AD3-87F6-9FE1DD0DE1F6@kernel.crashing.org> From: Kumar Gala To: Segher Boessenkool In-Reply-To: <7c624bb773b7c8df8357a3b151e2d9fa@kernel.crashing.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v924) Subject: Re: [PATCH] [POWERPC] Cleanup mpic nodes in .dts Date: Mon, 2 Jun 2008 18:07:09 -0500 References: <1212180199-968-1-git-send-email-galak@kernel.crashing.org> <701fe7d26b27ceaffae6e3b77bf94cf7@kernel.crashing.org> <4E62E532-1E3D-4109-B6C4-152F39567CA8@kernel.crashing.org> <7c624bb773b7c8df8357a3b151e2d9fa@kernel.crashing.org> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jun 2, 2008, at 11:32 AM, Segher Boessenkool wrote: >>>> Removed clock-frequency and big-endian props as they aren't >>>> specified >>>> anywhere. >>> >>> If you remove "big-endian", you'll have to provide some other way >>> to get that information (like, some new "compatible" value). >> >> I'm all for "big-endian" but we don't spec this anywhere and aren't >> using it right now. So until we have an real need to start an >> extended mpic definition I'm getting rid of it. > > If we would remove everything insufficiently documented, not much > would > be left. This doesn't seem very productive to me. Could you instead > just add some TODO somewhere? we were already inconsistent here so I've made all things equal and baselined. >>> Dunno if we need "clock-frequency". >> >> Not used today. > > Sure, the kernel might not use it today, but that's no reason to > remove > stuff from the device tree. > > I'm not against removing "clock-frequency" though, it's not well- > defined, > and what would it be useful for anyway? As Scott pointed it it could be used for the frequency of the timers that exist in OpenPIC. >>> This patch also removes "built-in" properties. I'm all for that, >>> but the patch description didn't say it does. >>> >> will add that to the commit message. > > Thanks. I'm sticking to removing the cruft and if/when we need it some can add it properly. - k