From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from TX2EHSOBE007.bigfish.com (tx2ehsobe004.messaging.microsoft.com [65.55.88.14]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 83ACDB6F71 for ; Wed, 30 Nov 2011 08:48:21 +1100 (EST) Message-ID: <4ED5531C.6030104@freescale.com> Date: Tue, 29 Nov 2011 15:48:12 -0600 From: Scott Wood MIME-Version: 1.0 To: Subject: Re: [PATCH v2] Integrated Flash Controller support References: <1320053901-23801-1-git-send-email-b35362@freescale.com> <8EDB3DC6-63E5-4D5C-BB52-15F32B85C5DD@kernel.crashing.org> <1322602860.2150.10.camel@koala> In-Reply-To: <1322602860.2150.10.camel@koala> Content-Type: text/plain; charset="UTF-8" Cc: Artem.Bityutskiy@nokia.com, Li Yang-R58472 , "linuxppc-dev@lists.ozlabs.org list" , "b35362@freescale.com>" , "linux-kernel@vger.kernel.org Kernel" , linux-mtd@lists.infradead.org, Andrew Morton , David Woodhouse List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11/29/2011 03:40 PM, Artem Bityutskiy wrote: > On Thu, 2011-11-24 at 08:24 -0600, Kumar Gala wrote: >> On Nov 22, 2011, at 9:41 PM, Kumar Gala wrote: >> >>> >>> On Oct 31, 2011, at 4:38 AM, wrote: >>> >>>> From: Liu Shuo >>>> >>>> Integrated Flash Controller supports various flashes like NOR, NAND >>>> and other devices using NOR, NAND and GPCM Machine available on it. >>>> IFC supports four chip selects. >>>> >>>> Signed-off-by: Dipen Dudhat >>>> Signed-off-by: Scott Wood >>>> Signed-off-by: Li Yang >>>> Signed-off-by: Liu Shuo >>>> --- >>>> arch/powerpc/Kconfig | 4 + >>>> arch/powerpc/include/asm/fsl_ifc.h | 834 ++++++++++++++++++++++++++++++++++++ >>>> arch/powerpc/sysdev/Makefile | 1 + >>>> arch/powerpc/sysdev/fsl_ifc.c | 322 ++++++++++++++ >>>> 4 files changed, 1161 insertions(+), 0 deletions(-) >>>> create mode 100644 arch/powerpc/include/asm/fsl_ifc.h >>>> create mode 100644 arch/powerpc/sysdev/fsl_ifc.c >>> >>> Guys, >>> >>> How are we handling this patchset since it touches drivers/mtd/nand? > > I do not see it touching MTD from the diffstat above. I am a little bit > confused why a flash controller is added to > arch/powerpc/sysdev/fsl_ifc.c ? It's really a bus controller, with NOR, NAND, and general-purpose modes settable per chipselect. The actual NAND driver goes in drivers/mtd/nand, and is apparently in a separate patch (probably due to separate maintenance domains). It's the same situation as arch/powerpc/sysdev/fsl_lbc.c versus drivers/mtd/nand/fsl_elbc_nand.c and drivers/mtd/nand/fsl_upm.c. -Scott