From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Gala Kumar-B11780 <B11780@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls
Date: Tue, 29 Nov 2011 16:53:32 -0600 [thread overview]
Message-ID: <4ED5626C.1080201@freescale.com> (raw)
In-Reply-To: <F763A5A8-8F4B-477A-ADD3-EDEF71C8F801@kernel.crashing.org>
Kumar Gala wrote:
>> > The only fix I can think of is to move "fsl,eloplus-dma" into mpc85xx_common_ids[]. I'll post a patch that does that, and we can discuss it.
> what if you make the p1022_ds_ids call first? Maybe we need to add 'soc' to p1022_ds_ids list
Reversing the calls does not help. p1022_ds_ids[] is ignored either way. The same problem exists in mpc85xx_publish_devices(), so this patch breaks several boards.
Copying lines into p1022_ds_ids[] causes kernel BUGS() like this:
sysfs: cannot create duplicate filename '/devices/e0005000.localbus'
because we end up duplicating probes.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-11-29 22:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 17:56 [PATCH 1/6] powerpc/85xx: separate cpm2 pic init Dmitry Eremin-Solenikov
2011-11-17 17:56 ` [PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls Dmitry Eremin-Solenikov
2011-11-24 7:15 ` Kumar Gala
2011-11-28 23:42 ` Tabi Timur-B04825
2011-11-29 15:48 ` Kumar Gala
2011-11-29 16:17 ` Timur Tabi
2011-11-29 16:20 ` Timur Tabi
2011-11-29 16:38 ` Kumar Gala
2011-11-29 18:52 ` Timur Tabi
2011-11-29 19:59 ` Kumar Gala
2011-11-29 22:53 ` Timur Tabi [this message]
2011-11-29 19:46 ` Scott Wood
2011-11-17 17:56 ` [PATCH 3/6] powerpc/85xx: separate MPIC handling code Dmitry Eremin-Solenikov
2011-11-17 18:30 ` Lee Nipper
2011-11-17 18:43 ` Dmitry Eremin-Solenikov
2011-11-17 21:20 ` Stephen Rothwell
2011-11-17 21:33 ` Scott Wood
2011-11-17 17:56 ` [PATCH 4/6] powerpc/85xx: unify common parts of *_setup_arch Dmitry Eremin-Solenikov
2011-11-17 17:56 ` [PATCH 5/6] powerpc/85xx: separate i8259 handling to common function Dmitry Eremin-Solenikov
2011-11-17 17:56 ` [PATCH 6/6] poewrpc/85xx: headers cleanup Dmitry Eremin-Solenikov
2011-11-17 21:22 ` Stephen Rothwell
2011-11-24 7:15 ` [PATCH 1/6] powerpc/85xx: separate cpm2 pic init Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED5626C.1080201@freescale.com \
--to=timur@freescale.com \
--cc=B11780@freescale.com \
--cc=dbaryshkov@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).