From: Scott Wood <scottwood@freescale.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Tabi Timur-B04825 <B04825@freescale.com>
Subject: Re: [PATCH] DTS: fix the bug and add the chip compatible for eSDHC
Date: Wed, 4 Jan 2012 13:19:03 -0600 [thread overview]
Message-ID: <4F04A627.7060803@freescale.com> (raw)
In-Reply-To: <8A2FC72B45BB5A4C9F801431E06AE48F1165E585@039-SN1MPN1-005.039d.mgd.msft.net>
On 01/03/2012 09:14 PM, Huang Changming-R66093 wrote:
>
>
>> -----Original Message-----
>> From: Tabi Timur-B04825
>> Sent: Tuesday, January 03, 2012 4:30 AM
>> To: Huang Changming-R66093
>> Cc: linuxppc-dev@lists.ozlabs.org; Huang Changming-R66093
>> Subject: Re: [PATCH] DTS: fix the bug and add the chip compatible for
>> eSDHC
>>
>> On Fri, Dec 23, 2011 at 12:10 AM, <r66093@freescale.com> wrote:
>>>
>>> Accordint to latest kernel, the auto-cmd12 property should be
>>> "sdhci,auto-cmd12", and according to the SDHC binding and the
>>> workaround for the special chip, add the chip compatible for eSDHC:
>>> "fsl,p1022-esdhc", "fsl,mpc8536-esdhc", "fsl,p2020-esdhc" and
>> "fsl,p1010-esdhc".
>>
>> Please do not use the phrase "fix the bug" in patch summaries.
>>
> Then, could you tell me how to describe it?
The subject line should be something like:
powerpc/fsl: esdhc node fixes
Phrases like "Fix the bug" or "fix the issue" could apply to lots of
patches and don't really add anything, especially in the subject line
where there isn't much space and you want to clearly and concisely
identify what this patch is about.
-Scott
prev parent reply other threads:[~2012-01-04 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 6:10 [PATCH] DTS: fix the bug and add the chip compatible for eSDHC r66093
2012-01-02 18:27 ` Scott Wood
2012-01-04 3:11 ` Huang Changming-R66093
2012-01-04 17:37 ` Scott Wood
2012-01-02 20:30 ` Tabi Timur-B04825
2012-01-04 3:14 ` Huang Changming-R66093
2012-01-04 19:19 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F04A627.7060803@freescale.com \
--to=scottwood@freescale.com \
--cc=B04825@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).