* [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE and related
@ 2012-01-31 10:15 Claudiu Manoil
2012-01-31 19:12 ` Scott Wood
0 siblings, 1 reply; 3+ messages in thread
From: Claudiu Manoil @ 2012-01-31 10:15 UTC (permalink / raw)
To: linuxppc-dev
CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undeclared here (not in a function)
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected declaration specifiers or '...' before string constant
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function declaration isn't a prototype
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected declaration specifiers or '...' before string constant
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function declaration isn't a prototype
make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
...
CC arch/powerpc/sysdev/fsl_85xx_cache_sram.o
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names (without types) in function declaration
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (without types) in function declaration
make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1
Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
---
arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
index 1164158..92cce8d 100644
--- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
+++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
@@ -24,6 +24,7 @@
*/
#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/slab.h>
#include <linux/err.h>
#include <linux/of_platform.h>
diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
index 5f88797..1957e53 100644
--- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
+++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
@@ -21,6 +21,7 @@
*/
#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/of_platform.h>
#include <asm/io.h>
--
1.6.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE and related
2012-01-31 10:15 [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE and related Claudiu Manoil
@ 2012-01-31 19:12 ` Scott Wood
2012-02-01 11:23 ` Manoil Claudiu-B08782
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2012-01-31 19:12 UTC (permalink / raw)
To: Claudiu Manoil; +Cc: linuxppc-dev
On 01/31/2012 04:15 AM, Claudiu Manoil wrote:
> CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undeclared here (not in a function)
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected declaration specifiers or '...' before string constant
> cc1: warnings being treated as errors
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function declaration isn't a prototype
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected declaration specifiers or '...' before string constant
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function declaration isn't a prototype
> make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
>
> ...
>
> CC arch/powerpc/sysdev/fsl_85xx_cache_sram.o
> cc1: warnings being treated as errors
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names (without types) in function declaration
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (without types) in function declaration
> make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1
>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
> ---
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> index 1164158..92cce8d 100644
> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> @@ -24,6 +24,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/err.h>
> #include <linux/of_platform.h>
> diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> index 5f88797..1957e53 100644
> --- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> +++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> @@ -21,6 +21,7 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/module.h>
> #include <linux/of_platform.h>
> #include <asm/io.h>
>
I believe <linux/export.h> is what you're supposed to include for this
these days.
-Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE and related
2012-01-31 19:12 ` Scott Wood
@ 2012-02-01 11:23 ` Manoil Claudiu-B08782
0 siblings, 0 replies; 3+ messages in thread
From: Manoil Claudiu-B08782 @ 2012-02-01 11:23 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: linuxppc-dev@lists.ozlabs.org
Hi,
You're right, <linux/export.h> is better for arch/powerpc/sysdev/fsl_85xx_c=
ache_sram.c.
However, it is not enough for arch/powerpc/sysdev/fsl_85xx_l2ctlr.c, as thi=
s one is defined as a module.
I'll resend the patch (with <linux/export.h> for fsl_85xx_cache_sram.c), if=
that's fine with you.
Thanks,
Claudiu
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, January 31, 2012 9:12 PM
> To: Manoil Claudiu-B08782
> Cc: linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE
> and related
>=20
> On 01/31/2012 04:15 AM, Claudiu Manoil wrote:
> > CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE'
> > undeclared here (not in a function)
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected
> > declaration specifiers or '...' before string constant
> > cc1: warnings being treated as errors
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to
> 'int' in declaration of 'MODULE_DESCRIPTION'
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function
> > declaration isn't a prototype
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected
> > declaration specifiers or '...' before string constant
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to
> 'int' in declaration of 'MODULE_LICENSE'
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function
> > declaration isn't a prototype
> > make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
> >
> > ...
> >
> > CC arch/powerpc/sysdev/fsl_85xx_cache_sram.o
> > cc1: warnings being treated as errors
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to
> 'int' in declaration of 'EXPORT_SYMBOL'
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names
> > (without types) in function declaration
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to
> 'int' in declaration of 'EXPORT_SYMBOL'
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names
> > (without types) in function declaration
> > make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1
> >
> > Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
> > ---
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 1 +
> > 2 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > index 1164158..92cce8d 100644
> > --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > @@ -24,6 +24,7 @@
> > */
> >
> > #include <linux/kernel.h>
> > +#include <linux/module.h>
> > #include <linux/slab.h>
> > #include <linux/err.h>
> > #include <linux/of_platform.h>
> > diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > index 5f88797..1957e53 100644
> > --- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > +++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > @@ -21,6 +21,7 @@
> > */
> >
> > #include <linux/kernel.h>
> > +#include <linux/module.h>
> > #include <linux/of_platform.h>
> > #include <asm/io.h>
> >
>=20
> I believe <linux/export.h> is what you're supposed to include for this
> these days.
>=20
> -Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-01 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-31 10:15 [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE and related Claudiu Manoil
2012-01-31 19:12 ` Scott Wood
2012-02-01 11:23 ` Manoil Claudiu-B08782
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).