From: Scott Wood <scottwood@freescale.com>
To: Timur Tabi <b04825@freescale.com>
Cc: Li Yang-R58472 <r58472@freescale.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/85xx: fix problem that prevents PHYS_64BIT from configurable
Date: Fri, 17 Feb 2012 18:56:12 -0600 [thread overview]
Message-ID: <4F3EF72C.2090305@freescale.com> (raw)
In-Reply-To: <4F3EDC35.5070904@freescale.com>
On 02/17/2012 05:01 PM, Timur Tabi wrote:
> So I noticed something else. PHYS_64BIT is not defined in
> mpc85xx_smp_defconfig.
It couldn't have been, since it was selected by another kconfig option.
defconfigs only hold non-default options.
> However, that select statement also means that we can't build a 32-bit
> kernel. This is a problem for mpc85xx_defconfig, because that defconfig
> includes support for the MPC8540ADS. The 8540 has an e500v1 core which
> doesn't support MAS7 (i.e. no 36-bit physical addresses).
It's not a problem for 8540, just lost optimization potential.
> So any patch that removes "select PHYS_64BIT" from an mpc85xx_defconfig
> board must also turn on that option in the defconfig. The patches from me
> and Leo don't do that.
Yes, or maybe make it "default y", and/or require an "I know what I'm
doing" option to be set for it to be unset if a board otherwise wants it.
The ability to turn it off is potentially useful for any board, since
the address map is determined by boot software which can be changed, but
we shouldn't make it too easy to fail to select it for boards that
normally require it.
-Scott
next prev parent reply other threads:[~2012-02-18 0:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 12:10 [PATCH 1/2] powerpc/85xx: fix problem that prevents PHYS_64BIT from configurable Li Yang
2012-02-16 12:10 ` [PATCH 2/2] powerpc/85xx: add a 36-bit corenet default config Li Yang
2012-02-16 15:56 ` [PATCH 1/2] powerpc/85xx: fix problem that prevents PHYS_64BIT from configurable Tabi Timur-B04825
2012-02-16 15:57 ` Tabi Timur-B04825
2012-02-17 1:27 ` Kumar Gala
2012-02-17 4:32 ` Li Yang-R58472
2012-02-17 8:43 ` Benjamin Herrenschmidt
2012-02-17 16:22 ` Tabi Timur-B04825
2012-02-17 21:10 ` Benjamin Herrenschmidt
2012-02-17 21:17 ` Timur Tabi
2012-02-17 23:01 ` Timur Tabi
2012-02-18 0:56 ` Scott Wood [this message]
2012-02-18 2:19 ` Benjamin Herrenschmidt
2012-02-20 20:30 ` Scott Wood
2012-02-17 8:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3EF72C.2090305@freescale.com \
--to=scottwood@freescale.com \
--cc=b04825@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).