From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>,
<benh@kernel.crashing.org>, <scottwood@freescale.com>,
<dbaryshkov@gmail.com>, <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice
Date: Wed, 7 Mar 2012 15:41:53 -0600 [thread overview]
Message-ID: <4F57D621.7090505@freescale.com> (raw)
In-Reply-To: <1322669957-8259-1-git-send-email-timur@freescale.com>
Timur Tabi wrote:
> Commit 46d026ac ("powerpc/85xx: consolidate of_platform_bus_probe calls")
> replaced platform-specific of_device_id tables with a single function
> that probes the most of the busses in 85xx device trees. If a specific
> platform needed additional busses probed, then it could call
> of_platform_bus_probe() again. Typically, the additional platform-specific
> busses are children of existing busses that have already been probed.
> of_platform_bus_probe() does not handle those child busses automatically.
>
> Unfortunately, this doesn't actually work. The second (platform-specific)
> call to of_platform_bus_probe() never finds any of the busses it's asked
> to find.
>
> To remedy this, the platform-specific of_device_id tables are eliminated,
> and their entries are merged into mpc85xx_common_ids[], so that all busses
> are probed at once.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
Kumar, without this patch, audio is broken on the P1022DS in your 'merge'
branch. I posted it back in November, six days after you applied the
patch that broke the P1022DS.
Is there any chance of getting this into 3.3? This is a real bug fix, and
I would hate for audio to be broken in 3.3.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-03-07 21:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 16:19 [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice Timur Tabi
2012-03-07 21:41 ` Timur Tabi [this message]
2012-03-16 20:46 ` Kumar Gala
2012-03-16 20:50 ` Timur Tabi
2012-03-19 16:04 ` Grant Likely
2012-03-19 18:43 ` Timur Tabi
2012-03-20 17:09 ` Grant Likely
2012-03-20 17:25 ` Timur Tabi
2012-03-21 15:15 ` Timur Tabi
2012-03-27 18:18 ` Timur Tabi
2012-03-28 5:01 ` Grant Likely
2012-03-21 15:08 ` Kumar Gala
2012-04-19 20:15 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F57D621.7090505@freescale.com \
--to=timur@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=dbaryshkov@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).