linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Diana CRACIUN <diana.craciun@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/dts: Removed fsl,msi property from dts.
Date: Wed, 21 Mar 2012 17:33:25 +0200	[thread overview]
Message-ID: <4F69F4C5.6090708@freescale.com> (raw)
In-Reply-To: <36B1F034-98A1-4571-8B94-A01D345935DF@kernel.crashing.org>

On 03/16/2012 09:33 PM, Kumar Gala wrote:
> On Feb 9, 2012, at 7:41 AM, Diana Craciun wrote:
>
>> From: Diana CRACIUN<Diana.Craciun@freescale.com>
>>
>> The association in the decice tree between PCI and MSI
>> using fsl,msi property was an artificial one and it does
>> not reflect the actual hardware.
>>
>> Signed-off-by: Diana CRACIUN<Diana.Craciun@freescale.com>
>> ---
>> arch/powerpc/boot/dts/p2041rdb.dts |    3 ---
>> arch/powerpc/boot/dts/p3041ds.dts  |    4 ----
>> arch/powerpc/boot/dts/p3060qds.dts |    2 --
>> arch/powerpc/boot/dts/p4080ds.dts  |    3 ---
>> arch/powerpc/boot/dts/p5020ds.dts  |    4 ----
>> 5 files changed, 0 insertions(+), 16 deletions(-)
> Should we not also remove the code associated with this property?
>
> - k

No. The property may be present in the device tree when running under 
Freescale hypervisor and it is used to skip the MSI nodes which are not 
mapped in PAMU.

The code in kernel handles both situations: when the property is present 
and in this case it searches only the corresponding MSI device for 
available interrupts and when the property is not present and in this 
case it loops over all the MSI devices.

Diana

  reply	other threads:[~2012-03-21 15:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 13:41 [PATCH] powerpc/dts: Removed fsl,msi property from dts Diana Craciun
2012-02-09 16:04 ` Tabi Timur-B04825
2012-03-16 19:33 ` Kumar Gala
2012-03-21 15:33   ` Diana CRACIUN [this message]
2012-03-21 17:21 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F69F4C5.6090708@freescale.com \
    --to=diana.craciun@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).