* [PATCH] powerpc/dts: Removed fsl,msi property from dts.
@ 2012-02-09 13:41 Diana Craciun
2012-02-09 16:04 ` Tabi Timur-B04825
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Diana Craciun @ 2012-02-09 13:41 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Diana CRACIUN
From: Diana CRACIUN <Diana.Craciun@freescale.com>
The association in the decice tree between PCI and MSI
using fsl,msi property was an artificial one and it does
not reflect the actual hardware.
Signed-off-by: Diana CRACIUN <Diana.Craciun@freescale.com>
---
arch/powerpc/boot/dts/p2041rdb.dts | 3 ---
arch/powerpc/boot/dts/p3041ds.dts | 4 ----
arch/powerpc/boot/dts/p3060qds.dts | 2 --
arch/powerpc/boot/dts/p4080ds.dts | 3 ---
arch/powerpc/boot/dts/p5020ds.dts | 4 ----
5 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/boot/dts/p2041rdb.dts b/arch/powerpc/boot/dts/p2041rdb.dts
index 4f957db..2852139 100644
--- a/arch/powerpc/boot/dts/p2041rdb.dts
+++ b/arch/powerpc/boot/dts/p2041rdb.dts
@@ -135,7 +135,6 @@
reg = <0xf 0xfe200000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
- fsl,msi = <&msi0>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -151,7 +150,6 @@
reg = <0xf 0xfe201000 0 0x1000>;
ranges = <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x20000000
0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
- fsl,msi = <&msi1>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -167,7 +165,6 @@
reg = <0xf 0xfe202000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x40000000 0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
- fsl,msi = <&msi2>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
diff --git a/arch/powerpc/boot/dts/p3041ds.dts b/arch/powerpc/boot/dts/p3041ds.dts
index f469145..22a215e 100644
--- a/arch/powerpc/boot/dts/p3041ds.dts
+++ b/arch/powerpc/boot/dts/p3041ds.dts
@@ -173,7 +173,6 @@
reg = <0xf 0xfe200000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
- fsl,msi = <&msi0>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -189,7 +188,6 @@
reg = <0xf 0xfe201000 0 0x1000>;
ranges = <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x20000000
0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
- fsl,msi = <&msi1>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -205,7 +203,6 @@
reg = <0xf 0xfe202000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x40000000 0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
- fsl,msi = <&msi2>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -221,7 +218,6 @@
reg = <0xf 0xfe203000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x60000000 0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8030000 0 0x00010000>;
- fsl,msi = <&msi2>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
diff --git a/arch/powerpc/boot/dts/p3060qds.dts b/arch/powerpc/boot/dts/p3060qds.dts
index 529042e..9ae875c 100644
--- a/arch/powerpc/boot/dts/p3060qds.dts
+++ b/arch/powerpc/boot/dts/p3060qds.dts
@@ -212,7 +212,6 @@
reg = <0xf 0xfe200000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
- fsl,msi = <&msi0>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -228,7 +227,6 @@
reg = <0xf 0xfe201000 0 0x1000>;
ranges = <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x20000000
0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
- fsl,msi = <&msi1>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
diff --git a/arch/powerpc/boot/dts/p4080ds.dts b/arch/powerpc/boot/dts/p4080ds.dts
index 6d60e54..3e20460 100644
--- a/arch/powerpc/boot/dts/p4080ds.dts
+++ b/arch/powerpc/boot/dts/p4080ds.dts
@@ -141,7 +141,6 @@
reg = <0xf 0xfe200000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
- fsl,msi = <&msi0>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -157,7 +156,6 @@
reg = <0xf 0xfe201000 0 0x1000>;
ranges = <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x20000000
0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
- fsl,msi = <&msi1>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -173,7 +171,6 @@
reg = <0xf 0xfe202000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x40000000 0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
- fsl,msi = <&msi2>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
diff --git a/arch/powerpc/boot/dts/p5020ds.dts b/arch/powerpc/boot/dts/p5020ds.dts
index 1c25068..27c07ed 100644
--- a/arch/powerpc/boot/dts/p5020ds.dts
+++ b/arch/powerpc/boot/dts/p5020ds.dts
@@ -173,7 +173,6 @@
reg = <0xf 0xfe200000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x00000000 0x0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8000000 0x0 0x00010000>;
- fsl,msi = <&msi0>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -189,7 +188,6 @@
reg = <0xf 0xfe201000 0 0x1000>;
ranges = <0x02000000 0x0 0xe0000000 0xc 0x20000000 0x0 0x20000000
0x01000000 0x0 0x00000000 0xf 0xf8010000 0x0 0x00010000>;
- fsl,msi = <&msi1>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -205,7 +203,6 @@
reg = <0xf 0xfe202000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x40000000 0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
- fsl,msi = <&msi2>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
@@ -221,7 +218,6 @@
reg = <0xf 0xfe203000 0 0x1000>;
ranges = <0x02000000 0 0xe0000000 0xc 0x60000000 0 0x20000000
0x01000000 0 0x00000000 0xf 0xf8030000 0 0x00010000>;
- fsl,msi = <&msi2>;
pcie@0 {
ranges = <0x02000000 0 0xe0000000
0x02000000 0 0xe0000000
--
1.7.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/dts: Removed fsl,msi property from dts.
2012-02-09 13:41 [PATCH] powerpc/dts: Removed fsl,msi property from dts Diana Craciun
@ 2012-02-09 16:04 ` Tabi Timur-B04825
2012-03-16 19:33 ` Kumar Gala
2012-03-21 17:21 ` Kumar Gala
2 siblings, 0 replies; 5+ messages in thread
From: Tabi Timur-B04825 @ 2012-02-09 16:04 UTC (permalink / raw)
To: Craciun Diana Madalina-STFD002; +Cc: linuxppc-dev@lists.ozlabs.org
On Thu, Feb 9, 2012 at 7:41 AM, Diana Craciun
<diana.craciun@freescale.com> wrote:
> From: Diana CRACIUN <Diana.Craciun@freescale.com>
>
> The association in the decice tree between PCI and MSI
> using fsl,msi property was an artificial one and it does
> not reflect the actual hardware.
>
> Signed-off-by: Diana CRACIUN <Diana.Craciun@freescale.com>
Acked-by: Timur Tabi <timur@freescale.com>
--=20
Timur Tabi
Linux kernel developer at Freescale=
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/dts: Removed fsl,msi property from dts.
2012-02-09 13:41 [PATCH] powerpc/dts: Removed fsl,msi property from dts Diana Craciun
2012-02-09 16:04 ` Tabi Timur-B04825
@ 2012-03-16 19:33 ` Kumar Gala
2012-03-21 15:33 ` Diana CRACIUN
2012-03-21 17:21 ` Kumar Gala
2 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2012-03-16 19:33 UTC (permalink / raw)
To: Diana Craciun; +Cc: linuxppc-dev
On Feb 9, 2012, at 7:41 AM, Diana Craciun wrote:
> From: Diana CRACIUN <Diana.Craciun@freescale.com>
>
> The association in the decice tree between PCI and MSI
> using fsl,msi property was an artificial one and it does
> not reflect the actual hardware.
>
> Signed-off-by: Diana CRACIUN <Diana.Craciun@freescale.com>
> ---
> arch/powerpc/boot/dts/p2041rdb.dts | 3 ---
> arch/powerpc/boot/dts/p3041ds.dts | 4 ----
> arch/powerpc/boot/dts/p3060qds.dts | 2 --
> arch/powerpc/boot/dts/p4080ds.dts | 3 ---
> arch/powerpc/boot/dts/p5020ds.dts | 4 ----
> 5 files changed, 0 insertions(+), 16 deletions(-)
Should we not also remove the code associated with this property?
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/dts: Removed fsl,msi property from dts.
2012-03-16 19:33 ` Kumar Gala
@ 2012-03-21 15:33 ` Diana CRACIUN
0 siblings, 0 replies; 5+ messages in thread
From: Diana CRACIUN @ 2012-03-21 15:33 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On 03/16/2012 09:33 PM, Kumar Gala wrote:
> On Feb 9, 2012, at 7:41 AM, Diana Craciun wrote:
>
>> From: Diana CRACIUN<Diana.Craciun@freescale.com>
>>
>> The association in the decice tree between PCI and MSI
>> using fsl,msi property was an artificial one and it does
>> not reflect the actual hardware.
>>
>> Signed-off-by: Diana CRACIUN<Diana.Craciun@freescale.com>
>> ---
>> arch/powerpc/boot/dts/p2041rdb.dts | 3 ---
>> arch/powerpc/boot/dts/p3041ds.dts | 4 ----
>> arch/powerpc/boot/dts/p3060qds.dts | 2 --
>> arch/powerpc/boot/dts/p4080ds.dts | 3 ---
>> arch/powerpc/boot/dts/p5020ds.dts | 4 ----
>> 5 files changed, 0 insertions(+), 16 deletions(-)
> Should we not also remove the code associated with this property?
>
> - k
No. The property may be present in the device tree when running under
Freescale hypervisor and it is used to skip the MSI nodes which are not
mapped in PAMU.
The code in kernel handles both situations: when the property is present
and in this case it searches only the corresponding MSI device for
available interrupts and when the property is not present and in this
case it loops over all the MSI devices.
Diana
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/dts: Removed fsl,msi property from dts.
2012-02-09 13:41 [PATCH] powerpc/dts: Removed fsl,msi property from dts Diana Craciun
2012-02-09 16:04 ` Tabi Timur-B04825
2012-03-16 19:33 ` Kumar Gala
@ 2012-03-21 17:21 ` Kumar Gala
2 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2012-03-21 17:21 UTC (permalink / raw)
To: Diana Craciun; +Cc: linuxppc-dev
On Feb 9, 2012, at 7:41 AM, Diana Craciun wrote:
> From: Diana CRACIUN <Diana.Craciun@freescale.com>
>
> The association in the decice tree between PCI and MSI
> using fsl,msi property was an artificial one and it does
> not reflect the actual hardware.
>
> Signed-off-by: Diana CRACIUN <Diana.Craciun@freescale.com>
> ---
> arch/powerpc/boot/dts/p2041rdb.dts | 3 ---
> arch/powerpc/boot/dts/p3041ds.dts | 4 ----
> arch/powerpc/boot/dts/p3060qds.dts | 2 --
> arch/powerpc/boot/dts/p4080ds.dts | 3 ---
> arch/powerpc/boot/dts/p5020ds.dts | 4 ----
> 5 files changed, 0 insertions(+), 16 deletions(-)
applied
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-21 17:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09 13:41 [PATCH] powerpc/dts: Removed fsl,msi property from dts Diana Craciun
2012-02-09 16:04 ` Tabi Timur-B04825
2012-03-16 19:33 ` Kumar Gala
2012-03-21 15:33 ` Diana CRACIUN
2012-03-21 17:21 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).