From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Bryan Hundven <Bryan.Hundven@watchguard.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc/85xx: p2020rdb - move the NAND address.
Date: Fri, 30 Mar 2012 16:04:27 +0200 [thread overview]
Message-ID: <4F75BD6B.30609@linutronix.de> (raw)
In-Reply-To: <9460468D-281C-4960-839A-F8435638DE4B@kernel.crashing.org>
On 03/29/2012 03:10 PM, Kumar Gala wrote:
>> - include/configs/P1_P2_RDB.h
>>
>> #ifndef CONFIG_NAND_SPL
>> #define CONFIG_SYS_NAND_BASE 0xffa00000
>> #ifdef CONFIG_PHYS_64BIT
>> #define CONFIG_SYS_NAND_BASE_PHYS 0xfffa00000ull
>> #else
>> #define CONFIG_SYS_NAND_BASE_PHYS CONFIG_SYS_NAND_BASE
>> #endif
>> #else
>> #define CONFIG_SYS_NAND_BASE 0xfff00000
>> #ifdef CONFIG_PHYS_64BIT
>> #define CONFIG_SYS_NAND_BASE_PHYS 0xffff00000ull
>> #else
>> #define CONFIG_SYS_NAND_BASE_PHYS CONFIG_SYS_NAND_BASE
>> #endif
>> #endif
>>
>> - include/configs/p1_p2_rdb_pc.h
>>
>> #ifdef CONFIG_NAND_FSL_ELBC
>> #define CONFIG_SYS_NAND_BASE 0xff800000
>> #ifdef CONFIG_PHYS_64BIT
>> #define CONFIG_SYS_NAND_BASE_PHYS 0xfff800000ull
>> #else
>> #define CONFIG_SYS_NAND_BASE_PHYS CONFIG_SYS_NAND_BASE
>> #endif
>>
>
> There are two (well 3 since rdb-pc has both 32b& 36b) in the tree now:
>
> arch/powerpc/boot/dts/p2020rdb.dts
> arch/powerpc/boot/dts/p2020rdb-pc_32b.dts
> arch/powerpc/boot/dts/p2020rdb-pc_36b.dts
Okay. So I assume that one has the proper NAND address and my patch
should be reverted then. Do want a patch from me for that?
>> Since both system have the same SoC and the NAND_SPL is always linked
>> against 0xfff00000 I don't see anything wrong to relocate the NAND CS
>> later to 0xff800000 (or to 0xffa00000) and having it consistent among
>> both configs.
what about this thing? Should leave it as it or move to the same
location? Since I have no HW *I* would prefer not to touch it :)
>
> - k
Sebastian
next prev parent reply other threads:[~2012-03-30 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E9CCADB024EDCD44A9C1083605680C42B9053302@ES05CO.wgti.net>
2012-03-29 7:26 ` powerpc/85xx: p2020rdb - move the NAND address Sebastian Andrzej Siewior
2012-03-29 13:10 ` Kumar Gala
2012-03-29 18:28 ` Bryan Hundven
2012-03-29 23:17 ` Bryan Hundven
2012-03-30 14:04 ` Sebastian Andrzej Siewior [this message]
2012-03-31 14:48 ` Kumar Gala
2012-05-09 19:53 ` Sebastian Andrzej Siewior
2012-06-29 20:01 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F75BD6B.30609@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Bryan.Hundven@watchguard.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).