* [PATCH] powerpc: 512x: Fix mpc5121_clk_get()
@ 2012-03-26 19:01 Richard Weinberger
2012-04-09 13:06 ` Richard Weinberger
2012-04-11 9:06 ` Anatolij Gustschin
0 siblings, 2 replies; 3+ messages in thread
From: Richard Weinberger @ 2012-03-26 19:01 UTC (permalink / raw)
To: linuxppc-dev; +Cc: agust, paulus, linux-kernel, Richard Weinberger
If try_module_get() fails, mpc5121_clk_get() might return
a wrong clock.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
arch/powerpc/platforms/512x/clock.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/512x/clock.c b/arch/powerpc/platforms/512x/clock.c
index 1d8700f..9f771e0 100644
--- a/arch/powerpc/platforms/512x/clock.c
+++ b/arch/powerpc/platforms/512x/clock.c
@@ -54,14 +54,16 @@ static DEFINE_MUTEX(clocks_mutex);
static struct clk *mpc5121_clk_get(struct device *dev, const char *id)
{
struct clk *p, *clk = ERR_PTR(-ENOENT);
- int dev_match = 0;
- int id_match = 0;
+ int dev_match;
+ int id_match;
if (dev == NULL || id == NULL)
return clk;
mutex_lock(&clocks_mutex);
list_for_each_entry(p, &clocks, node) {
+ dev_match = id_match = 0;
+
if (dev == p->dev)
dev_match++;
if (strcmp(id, p->name) == 0)
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: 512x: Fix mpc5121_clk_get()
2012-03-26 19:01 [PATCH] powerpc: 512x: Fix mpc5121_clk_get() Richard Weinberger
@ 2012-04-09 13:06 ` Richard Weinberger
2012-04-11 9:06 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2012-04-09 13:06 UTC (permalink / raw)
To: Richard Weinberger; +Cc: paulus, agust, linuxppc-dev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
Am 26.03.2012 21:01, schrieb Richard Weinberger:
> If try_module_get() fails, mpc5121_clk_get() might return
> a wrong clock.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/powerpc/platforms/512x/clock.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/512x/clock.c b/arch/powerpc/platforms/512x/clock.c
> index 1d8700f..9f771e0 100644
> --- a/arch/powerpc/platforms/512x/clock.c
> +++ b/arch/powerpc/platforms/512x/clock.c
> @@ -54,14 +54,16 @@ static DEFINE_MUTEX(clocks_mutex);
> static struct clk *mpc5121_clk_get(struct device *dev, const char *id)
> {
> struct clk *p, *clk = ERR_PTR(-ENOENT);
> - int dev_match = 0;
> - int id_match = 0;
> + int dev_match;
> + int id_match;
>
> if (dev == NULL || id == NULL)
> return clk;
>
> mutex_lock(&clocks_mutex);
> list_for_each_entry(p, &clocks, node) {
> + dev_match = id_match = 0;
> +
> if (dev == p->dev)
> dev_match++;
> if (strcmp(id, p->name) == 0)
*ping*
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: 512x: Fix mpc5121_clk_get()
2012-03-26 19:01 [PATCH] powerpc: 512x: Fix mpc5121_clk_get() Richard Weinberger
2012-04-09 13:06 ` Richard Weinberger
@ 2012-04-11 9:06 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2012-04-11 9:06 UTC (permalink / raw)
To: Richard Weinberger; +Cc: paulus, linuxppc-dev, linux-kernel
On Mon, 26 Mar 2012 21:01:29 +0200
Richard Weinberger <richard@nod.at> wrote:
> If try_module_get() fails, mpc5121_clk_get() might return
> a wrong clock.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/powerpc/platforms/512x/clock.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
Anatolij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-11 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-26 19:01 [PATCH] powerpc: 512x: Fix mpc5121_clk_get() Richard Weinberger
2012-04-09 13:06 ` Richard Weinberger
2012-04-11 9:06 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).