From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
linux-ide@vger.kernel.org, "Thang Q. Nguyen" <tqnguyen@apm.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c
Date: Thu, 12 Apr 2012 16:05:07 -0400 [thread overview]
Message-ID: <4F873573.10406@pobox.com> (raw)
In-Reply-To: <4F7AE584.3050805@mvista.com>
On 04/03/2012 07:56 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 03-04-2012 14:12, Thang Q. Nguyen wrote:
>
>> Signed-off-by: Thang Q. Nguyen<tqnguyen@apm.com>
>> ---
>> Changes for v2:
>> - Use git rename feature to change the driver to the newname and for
>> easier review.
>
>> arch/powerpc/boot/dts/bluestone.dts | 21 +
>> drivers/ata/Makefile | 2 +-
>> drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} | 1371
>> ++++++++++++++--------
>> 3 files changed, 904 insertions(+), 490 deletions(-)
>> rename drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} (56%)
>
> You submitted a magapatch doing several things at once (some even
> needlessly) and even in two areas of the kernel. This needs proper
> splitting/description.
Agreed...
next prev parent reply other threads:[~2012-04-12 20:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 10:12 [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c Thang Q. Nguyen
2012-04-03 11:56 ` Sergei Shtylyov
2012-04-04 8:18 ` Thang Nguyen
2012-04-12 20:05 ` Jeff Garzik [this message]
2012-04-13 7:18 ` Thang Nguyen
2012-04-13 14:20 ` Jeff Garzik
2012-04-09 10:12 ` Sergei Shtylyov
2012-04-10 3:46 ` Thang Nguyen
2012-04-10 11:22 ` Sergei Shtylyov
2012-04-13 3:29 ` Thang Q. Nguyen
-- strict thread matches above, loose matches on Subject: below --
2012-03-27 10:26 Thang Q. Nguyen
2012-03-27 11:16 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F873573.10406@pobox.com \
--to=jgarzik@pobox.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rob.herring@calxeda.com \
--cc=sshtylyov@mvista.com \
--cc=tqnguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).