From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f51.google.com (mail-pz0-f51.google.com [209.85.210.51]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id C6710B7000 for ; Sat, 2 Jun 2012 02:59:14 +1000 (EST) Received: by dajt11 with SMTP id t11so3465696daj.38 for ; Fri, 01 Jun 2012 09:59:12 -0700 (PDT) Message-ID: <4FC8F4DB.2070906@gmail.com> Date: Fri, 01 Jun 2012 09:59:07 -0700 From: David Daney MIME-Version: 1.0 To: "Srivatsa S. Bhat" Subject: Re: [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code References: <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com> <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> In-Reply-To: <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Venkatesh Pallipadi , Jeremy Fitzhardinge , linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, peterz@infradead.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , mingo@kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xensource.com, Suresh Siddha , linux-sh@vger.kernel.org, x86@kernel.org, Ingo Molnar , paulmck@linux.vnet.ibm.com, Fenghua Yu , Mike Frysinger , Peter Zijlstra , nikunj@linux.vnet.ibm.com, Konrad Rzeszutek Wilk , rusty@rustcorp.com.au, Chris Metcalf , rjw@sisk.pl, yong.zhang0@gmail.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, Tony Luck , vatsa@linux.vnet.ibm.com, Ralf Baechle , Paul Mundt , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/01/2012 02:10 AM, Srivatsa S. Bhat wrote: > The per-cpu variable cpu_state is used in x86 and also used in other > architectures, to track the state of the cpu during bringup and hotplug. > Pull it out into generic code. > > Cc: Tony Luck > Cc: Fenghua Yu > Cc: Ralf Baechle > Cc: Benjamin Herrenschmidt > Cc: Paul Mundt > Cc: Chris Metcalf > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Konrad Rzeszutek Wilk > Cc: Jeremy Fitzhardinge > Cc: Peter Zijlstra > Cc: Andrew Morton > Cc: Mike Frysinger > Cc: Yong Zhang > Cc: Venkatesh Pallipadi > Cc: Suresh Siddha > Cc: linux-ia64@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: xen-devel@lists.xensource.com > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Srivatsa S. Bhat > --- > > arch/ia64/include/asm/cpu.h | 2 -- > arch/ia64/kernel/process.c | 1 + > arch/ia64/kernel/smpboot.c | 6 +----- > arch/mips/cavium-octeon/smp.c | 4 +--- > arch/powerpc/kernel/smp.c | 6 +----- > arch/sh/include/asm/smp.h | 2 -- > arch/sh/kernel/smp.c | 4 +--- > arch/tile/kernel/smpboot.c | 4 +--- > arch/x86/include/asm/cpu.h | 2 -- > arch/x86/kernel/smpboot.c | 4 +--- > arch/x86/xen/smp.c | 1 + > include/linux/smpboot.h | 1 + > kernel/smpboot.c | 4 ++++ > 13 files changed, 13 insertions(+), 28 deletions(-) > [...] > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 97e7ce9..93cd4b0 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -252,9 +253,6 @@ static void octeon_cpus_done(void) > > #ifdef CONFIG_HOTPLUG_CPU > > -/* State of each CPU. */ > -DEFINE_PER_CPU(int, cpu_state); > - > extern void fixup_irqs(void); > > static DEFINE_SPINLOCK(smp_reserve_lock); The Octeon bit: Acked-by: David Daney FWIW, the rest looks good too.