From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by ozlabs.org (Postfix) with ESMTP id E4E91B6F6E for ; Mon, 25 Jun 2012 23:36:27 +1000 (EST) Message-ID: <4FE86956.9020909@redhat.com> Date: Mon, 25 Jun 2012 16:36:22 +0300 From: Avi Kivity MIME-Version: 1.0 To: Caraman Mihai Claudiu-B02008 Subject: Re: [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs References: <1340627195-11544-1-git-send-email-mihai.caraman@freescale.com> <1340627195-11544-4-git-send-email-mihai.caraman@freescale.com> <4FE860CC.6080903@redhat.com> <300B73AA675FCE4A93EB4FC1D42459FF14F93A@039-SN2MPN1-013.039d.mgd.msft.net> In-Reply-To: <300B73AA675FCE4A93EB4FC1D42459FF14F93A@039-SN2MPN1-013.039d.mgd.msft.net> Content-Type: text/plain; charset=ISO-8859-1 Cc: "qemu-ppc@nongnu.org" , "linuxppc-dev@lists.ozlabs.org" , "kvm@vger.kernel.org" , "kvm-ppc@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/25/2012 04:24 PM, Caraman Mihai Claudiu-B02008 wrote: >> -----Original Message----- >> From: Avi Kivity [mailto:avi@redhat.com] >> Sent: Monday, June 25, 2012 4:00 PM >> To: Caraman Mihai Claudiu-B02008 >> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- >> dev@lists.ozlabs.org; qemu-ppc@nongnu.org >> Subject: Re: [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in >> sregs >> >> On 06/25/2012 03:26 PM, Mihai Caraman wrote: >> > Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs for >> > 64-bit hosts. >> > >> > Signed-off-by: Mihai Caraman >> > --- >> > arch/powerpc/kvm/booke.c | 14 ++++++++++++++ >> > 1 files changed, 14 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index >> > f9fa260..d15c4b5 100644 >> > --- a/arch/powerpc/kvm/booke.c >> > +++ b/arch/powerpc/kvm/booke.c >> > @@ -1052,6 +1052,9 @@ static void get_sregs_base(struct kvm_vcpu *vcpu, >> > u64 tb = get_tb(); >> > >> > sregs->u.e.features |= KVM_SREGS_E_BASE; >> > +#ifdef CONFIG_64BIT >> > + sregs->u.e.features |= KVM_SREGS_E_64; #endif >> > >> >> This is an ABI, but I see no trace of it in Documentation. > > The ppc sregs documentation in api.txt redirects to arch/powerpc/include/asm/kvm.h. > Isn't this enough? I guess it's okay. -- error compiling committee.c: too many arguments to function