From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: len.brown@intel.com, wency@cn.fujitsu.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, paulus@samba.org, minchan.kim@gmail.com,
cl@linux.com, linuxppc-dev@lists.ozlabs.org,
akpm@linux-foundation.org
Subject: Re: [RFC PATCH 2/12] memory-hogplug : check memory offline in offline_pages
Date: Thu, 28 Jun 2012 15:51:52 +0900 [thread overview]
Message-ID: <4FEBFF08.60502@jp.fujitsu.com> (raw)
In-Reply-To: <CAHGf_=qtt6_EWucC4B8R_jr71UTc9=QTJcDXz8Oo13C_nyu-mQ@mail.gmail.com>
Hi Kosaki-san,
2012/06/28 14:26, KOSAKI Motohiro wrote:
> On Wed, Jun 27, 2012 at 1:44 AM, Yasuaki Ishimatsu
> <isimatu.yasuaki@jp.fujitsu.com> wrote:
>> When offline_pages() is called to offlined memory, the function fails since
>> all memory has been offlined. In this case, the function should succeed.
>> The patch adds the check function into offline_pages().
>
> I don't understand your point. I think following misoperation should
> fail. Otherwise
> administrator have no way to know their fault.
>
> $ echo offline > memoryN/state
> $ echo offline > memoryN/state
>
> In general, we don't like to ignore an error except the standard require it.
I understood the intention of previous mail (why the caller can't check it? ).
I'll move memory_is_offline() to caller side.
>>
>> CC: Len Brown <len.brown@intel.com>
>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> CC: Paul Mackerras <paulus@samba.org>
>> CC: Christoph Lameter <cl@linux.com>
>> Cc: Minchan Kim <minchan.kim@gmail.com>
>> CC: Andrew Morton <akpm@linux-foundation.org>
>> CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>> CC: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>
>> ---
>> drivers/base/memory.c | 20 ++++++++++++++++++++
>> include/linux/memory.h | 1 +
>> mm/memory_hotplug.c | 5 +++++
>> 3 files changed, 26 insertions(+)
>>
>> Index: linux-3.5-rc4/drivers/base/memory.c
>> ===================================================================
>> --- linux-3.5-rc4.orig/drivers/base/memory.c 2012-06-26 13:28:16.726211752 +0900
>> +++ linux-3.5-rc4/drivers/base/memory.c 2012-06-26 13:34:22.423639904 +0900
>> @@ -70,6 +70,26 @@ void unregister_memory_isolate_notifier(
>> }
>> EXPORT_SYMBOL(unregister_memory_isolate_notifier);
>>
>> +bool memory_is_offline(unsigned long start_pfn, unsigned long end_pfn)
>
> I dislike this function name. 'memory' is too vague to me.
O.K.
I retry to change the name of the function.
>
>
>> +{
>> + struct memory_block *mem;
>> + struct mem_section *section;
>> + unsigned long pfn, section_nr;
>> +
>> + for (pfn = start_pfn; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
>> + section_nr = pfn_to_section_nr(pfn);
>> + section = __nr_to_section(section_nr);
>> + mem = find_memory_block(section);
>
> This seems to have strong sparse dependency.
Thanks.
I will consider other CONFIG_.
Thanks.
Yasuaki Ishimatsu
> Hm, I wonder why memory-hotplug.c can enable when X86_64_ACPI_NUMA.
>
> # eventually, we can have this option just 'select SPARSEMEM'
> config MEMORY_HOTPLUG
> bool "Allow for memory hot-add"
> depends on SPARSEMEM || X86_64_ACPI_NUMA
>
>
>> + if (!mem)
>> + continue;
>> + if (mem->state == MEM_OFFLINE)
>> + continue;
>> + return false;
>> + }
>> +
>> + return true;
>> +}
>> +
>> /*
>> * register_memory - Setup a sysfs device for a memory block
>> */
>> Index: linux-3.5-rc4/include/linux/memory.h
>> ===================================================================
>> --- linux-3.5-rc4.orig/include/linux/memory.h 2012-06-25 04:53:04.000000000 +0900
>> +++ linux-3.5-rc4/include/linux/memory.h 2012-06-26 13:34:22.424639891 +0900
>> @@ -120,6 +120,7 @@ extern int memory_isolate_notify(unsigne
>> extern struct memory_block *find_memory_block_hinted(struct mem_section *,
>> struct memory_block *);
>> extern struct memory_block *find_memory_block(struct mem_section *);
>> +extern bool memory_is_offline(unsigned long start_pfn, unsigned long end_pfn);
>> #define CONFIG_MEM_BLOCK_SIZE (PAGES_PER_SECTION<<PAGE_SHIFT)
>> enum mem_add_context { BOOT, HOTPLUG };
>> #endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */
>> Index: linux-3.5-rc4/mm/memory_hotplug.c
>> ===================================================================
>> --- linux-3.5-rc4.orig/mm/memory_hotplug.c 2012-06-26 13:28:16.743211538 +0900
>> +++ linux-3.5-rc4/mm/memory_hotplug.c 2012-06-26 13:48:38.264940468 +0900
>> @@ -887,6 +887,11 @@ static int __ref offline_pages(unsigned
>>
>> lock_memory_hotplug();
>>
>> + if (memory_is_offline(start_pfn, end_pfn)) {
>> + ret = 0;
>> + goto out;
>> + }
>> +
>> zone = page_zone(pfn_to_page(start_pfn));
>> node = zone_to_nid(zone);
>> nr_pages = end_pfn - start_pfn;
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-28 6:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 5:39 [RFC PATCH 0/12] memory-hotplug : hot-remove physical memory Yasuaki Ishimatsu
2012-06-27 5:42 ` [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory Yasuaki Ishimatsu
2012-06-27 6:10 ` David Rientjes
2012-06-27 7:14 ` Wen Congyang
2012-06-27 8:47 ` Wen Congyang
2012-06-28 3:01 ` Yasuaki Ishimatsu
2012-06-28 3:25 ` Wen Congyang
2012-06-28 4:50 ` Yasuaki Ishimatsu
2012-06-27 5:44 ` [RFC PATCH 2/12] memory-hogplug : check memory offline in offline_pages Yasuaki Ishimatsu
2012-06-27 6:16 ` David Rientjes
2012-06-28 7:01 ` Yasuaki Ishimatsu
2012-06-27 8:49 ` Wen Congyang
2012-06-28 5:06 ` Yasuaki Ishimatsu
2012-06-28 5:27 ` KOSAKI Motohiro
2012-06-28 6:01 ` Yasuaki Ishimatsu
2012-06-28 5:26 ` KOSAKI Motohiro
2012-06-28 6:51 ` Yasuaki Ishimatsu [this message]
2012-06-30 15:46 ` Jiang Liu
2012-07-02 2:53 ` Yasuaki Ishimatsu
2012-06-30 15:51 ` Jiang Liu
2012-07-02 2:56 ` Yasuaki Ishimatsu
2012-06-27 5:45 ` [RFC PATCH 3/12] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove Yasuaki Ishimatsu
2012-06-27 5:47 ` [RFC PATCH 4/12] memory-hotplug : remove /sys/firmware/memmap/X sysfs Yasuaki Ishimatsu
2012-06-28 6:32 ` Wen Congyang
2012-06-28 8:07 ` Yasuaki Ishimatsu
2012-06-28 8:38 ` Wen Congyang
2012-06-29 3:09 ` Yasuaki Ishimatsu
2012-06-27 5:48 ` [RFC PATCH 5/12] memory-hotplug : does not release memory region in PAGES_PER_SECTION chunks Yasuaki Ishimatsu
2012-06-27 5:52 ` [RFC PATCH 6/12] memory-hotplug : remove_memory calls __remove_pages Yasuaki Ishimatsu
2012-06-27 5:53 ` [RFC PATCH 7/12] memory-hotplug : check page type in get_page_bootmem Yasuaki Ishimatsu
2012-06-27 5:54 ` [RFC PATCH 8/12] memory-hotplug : move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmap Yasuaki Ishimatsu
2012-06-27 5:55 ` [RFC PATCH 9/12] memory-hotplug : implement register_page_bootmem_info_section of sparse-vmemmap Yasuaki Ishimatsu
2012-06-27 5:56 ` [RFC PATCH 10/12] memory-hotplug : free memmap " Yasuaki Ishimatsu
2012-06-30 15:58 ` Jiang Liu
2012-07-02 3:01 ` Yasuaki Ishimatsu
2012-06-27 5:57 ` [RFC PATCH 11/12] memory-hotplug : add node_device_release Yasuaki Ishimatsu
2012-06-27 5:59 ` [RFC PATCH 12/12] memory-hotplug : remove sysfs file of node Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEBFF08.60502@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan.kim@gmail.com \
--cc=paulus@samba.org \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).