From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org, anton@samba.org
Subject: Re: [PATCH -V1 2/9] arch/powerpc: Convert virtual address to a struct
Date: Fri, 29 Jun 2012 10:44:37 -0700 [thread overview]
Message-ID: <4FEDE985.5050902@linux.vnet.ibm.com> (raw)
In-Reply-To: <1340979457-26018-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
> diff --git a/arch/powerpc/include/asm/mmu-hash64.h b/arch/powerpc/include/asm/mmu-hash64.h
> index 1c65a59..5ff936b 100644
> --- a/arch/powerpc/include/asm/mmu-hash64.h
> +++ b/arch/powerpc/include/asm/mmu-hash64.h
> @@ -143,6 +143,10 @@ struct mmu_psize_def
> unsigned long sllp; /* SLB L||LP (exact mask to use in slbmte) */
> };
>
> +struct virt_addr {
> + unsigned long addr;
> +};
> +
> #endif /* __ASSEMBLY__ */
>
> /*
> @@ -1153,13 +1153,13 @@ void hash_preload(struct mm_struct *mm, unsigned long ea,
> /* WARNING: This is called from hash_low_64.S, if you change this prototype,
> * do not forget to update the assembly call site !
> */
I'd suggest having a similar warning next to the definition of struct
virt_addr, as any changes to it mean we'll need to adjust hash_low_64.S
> -void flush_hash_page(unsigned long va, real_pte_t pte, int psize, int ssize,
> +void flush_hash_page(struct virt_addr va, real_pte_t pte, int psize, int ssize,
> int local)
> {
> unsigned long hash, index, shift, hidx, slot;
>
> - DBG_LOW("flush_hash_page(va=%016lx)\n", va);
> - pte_iterate_hashed_subpages(pte, psize, va, index, shift) {
> + DBG_LOW("flush_hash_page(va=%016lx)\n", va.addr);
> + pte_iterate_hashed_subpages(pte, psize, va.addr, index, shift) {
> hash = hpt_hash(va, shift, ssize);
> hidx = __rpte_to_hidx(pte, index);
> if (hidx & _PTEIDX_SECONDARY)
--
Cody
next prev parent reply other threads:[~2012-06-29 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 14:17 [PATCH -V1 0/9] arch/powerpc: Add 64TB support to ppc64 Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 1/9] arch/powerpc: Use hpt_va to compute virtual address Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 2/9] arch/powerpc: Convert virtual address to a struct Aneesh Kumar K.V
2012-06-29 17:44 ` Cody P Schafer [this message]
2012-06-29 21:43 ` Benjamin Herrenschmidt
2012-06-29 14:17 ` [PATCH -V1 3/9] arch/powerpc: Simplify hpte_decode Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 4/9] arch/powerpc: Use vsid and segment offset to represent virtual address Aneesh Kumar K.V
2012-06-29 21:45 ` Benjamin Herrenschmidt
2012-07-01 7:53 ` Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 5/9] arch/powerpc: Make KERN_VIRT_SIZE not dependend on PGTABLE_RANGE Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 6/9] arch/powerpc: Increase the slice range to 64TB Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 7/9] arch/powerpc: Use 50 bits of VSID in slbmte Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 8/9] arch/powerpc: Use 32bit array for slb cache Aneesh Kumar K.V
2012-06-29 14:17 ` [PATCH -V1 9/9] arch/powerpc: Add 64TB support Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEDE985.5050902@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).