From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe004.messaging.microsoft.com [216.32.180.14]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 028C52C007C for ; Wed, 4 Jul 2012 13:17:19 +1000 (EST) From: Tabi Timur-B04825 To: Zhao Chenhui-B35336 Subject: Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync Date: Wed, 4 Jul 2012 03:17:12 +0000 Message-ID: <4FF3B5B6.8090400@freescale.com> References: <1341310879-5468-1-git-send-email-chenhui.zhao@freescale.com> <20120704031426.GA6133@localhost.localdomain> In-Reply-To: <20120704031426.GA6133@localhost.localdomain> Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Cc: Wood Scott-B07421 , Li Yang-R58472 , Zhao Chenhui-B35336 , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Zhao Chenhui wrote: > If the guts variable is NULL, it indicates there is error in dts or kerne= l. > We should fix the error, rather than ignore it. And that's why there's a warning message. Crashing the kernel is not=20 going to fix anything. > Moreover, if smp_85xx_ops.give/take_timebase is NULL, kernel can not do t= he timebase sync. Is that necessary for the kernel to boot? --=20 Timur Tabi Linux kernel developer at Freescale