From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Bogdan Hamciuc <bogdan.hamciuc@freescale.com>,
Varun Sethi <Varun.Sethi@freescale.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3 v2] powerpc/mpic: FSL MPIC error interrupt support.
Date: Mon, 9 Jul 2012 15:22:32 -0500 [thread overview]
Message-ID: <4FFB3D88.6030106@freescale.com> (raw)
In-Reply-To: <62D13F27-5E39-450E-953D-102DCA32AA9D@kernel.crashing.org>
On 07/09/2012 02:03 PM, Kumar Gala wrote:
>
> On Jul 9, 2012, at 3:47 AM, Varun Sethi wrote:
>
>> +int mpic_err_int_init(struct mpic *mpic, irq_hw_number_t irqnum)
>> +{
>
> Why can't we do this during mpic_init() time?
Are you willing to hardcode that IRQ 16 is the error interrupt, without
waiting to see an intspec?
>> + ret = request_irq(virq, fsl_error_int_handler, IRQF_NO_THREAD,
>> + "mpic-error-int", mpic);
>
> Hmm, should we be using irq_set_chained_handler() instead of request_irq
As I said last time, "that's how Varun initially did it and I asked him
to change it, because it gets a lot trickier to get things right, and I
didn't see what it was buying us." That original patch had locking
problems as a result.
Using the chained handler mechanism puts the responsibility on us to do
a lot of the generic stuff that's already perfectly well implemented in
generic code. We're implementing a cascade, not a new flow.
-Scott
next prev parent reply other threads:[~2012-07-09 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 8:47 [PATCH 3/3 v2] powerpc/mpic: FSL MPIC error interrupt support Varun Sethi
2012-07-09 19:03 ` Kumar Gala
2012-07-09 20:22 ` Scott Wood [this message]
2012-07-10 1:47 ` Kumar Gala
2012-07-10 9:39 ` Sethi Varun-B16395
2012-07-10 11:46 ` Kumar Gala
2012-07-10 9:26 ` Sethi Varun-B16395
-- strict thread matches above, loose matches on Subject: below --
2012-06-03 7:45 Varun Sethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFB3D88.6030106@freescale.com \
--to=scottwood@freescale.com \
--cc=Varun.Sethi@freescale.com \
--cc=bogdan.hamciuc@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).