linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Xu Jiucheng <Jiucheng.Xu@freescale.com>
Cc: Matthew McClintock <msm@freescale.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] powerpc/85xx: Create dts of each core in CAMP mode for P1021RDB-PC
Date: Tue, 10 Jul 2012 10:57:51 -0500	[thread overview]
Message-ID: <4FFC50FF.707@freescale.com> (raw)
In-Reply-To: <1341909561-6591-2-git-send-email-Jiucheng.Xu@freescale.com>

On 07/10/2012 03:39 AM, Xu Jiucheng wrote:
> +		crypto@30000 {
> +                        status = "disabled";
> +                };

Whitespace.

> +
> +		mpic: pic@40000 {
> +			protected-sources = <
> +			16 		/* ecm, mem, L2, pci0, pci1 */
> +			43 42 59	/* i2c, serial0, spi */
> +			47 63 62 	/* gpio, tdm */
> +			20 21 22 23	/* dma */
> +			03 02 		/* mdio */
> +			29 30 34	/* enet0-queue-group0 */
> +			17 18 24	/* enet0-queue-group1 */
> +			35 36 40	/* enet1-queue-group0 */
> +			51 52 67	/* enet1-queue-group1 */
> +			28 72 45 58 	/* usb, sdhci, crypto */
> +			0xb0 0xb1 0xb2	/* message */
> +			0xb3 0xb4 0xb5
> +			0xb6 0xb7
> +			0xe0 0xe1 0xe2	/* msi */
> +			0xe3 0xe4 0xe5
> +			0xe6 0xe7		/* sdhci, crypto , pci */
> +			>;
> +			pic-no-reset;
> +		};

Besides what Timur said, do we really need protected-sources now that we
have pic-no-reset?

-Scott

  parent reply	other threads:[~2012-07-10 15:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  8:39 [PATCH] powerpc/85xx: Add dts files for P1021RDB-PC board Xu Jiucheng
2012-07-10  8:39 ` [PATCH 2/2] powerpc/85xx: Create dts of each core in CAMP mode for P1021RDB-PC Xu Jiucheng
2012-07-10 12:25   ` Tabi Timur-B04825
2012-07-11 14:47     ` Kumar Gala
2012-07-11 14:49       ` Timur Tabi
2012-07-11 14:52         ` AW: " Schneider, Kolja
2012-07-11 14:56           ` Timur Tabi
2012-07-11 14:53         ` Kumar Gala
2012-07-11 14:56           ` Timur Tabi
2012-07-12  3:16             ` Kumar Gala
2012-07-12  3:53               ` Tabi Timur-B04825
2012-07-12  4:05                 ` Kumar Gala
2012-07-10 15:57   ` Scott Wood [this message]
2012-07-10 11:48 ` [PATCH] powerpc/85xx: Add dts files for P1021RDB-PC board Kumar Gala
2012-07-11  9:58   ` Jiucheng Xu
2012-07-11 12:31     ` Kumar Gala
2012-07-11 12:43 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFC50FF.707@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Jiucheng.Xu@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=msm@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).