From: Timur Tabi <timur@freescale.com>
To: Qiang Liu <qiang.liu@freescale.com>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>,
linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [linuxppc-release] [PATCH 4/4] Talitos: fix the issue of dma memory leak
Date: Tue, 10 Jul 2012 16:25:53 -0500 [thread overview]
Message-ID: <4FFC9DE1.5060502@freescale.com> (raw)
In-Reply-To: <1341900014-20915-1-git-send-email-qiang.liu@freescale.com>
Qiang Liu wrote:
> An error will be happened when test with mass data:
Please don't use the phrase "fix the issue" in patch summaries. It's
redundant.
This patch should be titled,
"drivers/crypto: fix memory leak in Talitos driver"
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index 81f8497..a7da48c 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -264,7 +264,7 @@ static void flush_channel(struct device *dev, int ch, int error, int reset_ch)
> else
> status = error;
>
> - dma_unmap_single(dev, request->dma_desc,
> + dma_unmap_single(priv->dev, request->dma_desc,
You have an indentation problem here.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-07-10 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 6:00 [PATCH 4/4] Talitos: fix the issue of dma memory leak Qiang Liu
2012-07-10 21:25 ` Timur Tabi [this message]
2012-07-11 2:30 ` [linuxppc-release] " Liu Qiang-B32616
2012-07-11 7:09 ` Geanta Neag Horia Ioan-B05471
2012-07-11 7:18 ` Liu Qiang-B32616
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC9DE1.5060502@freescale.com \
--to=timur@freescale.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).