From: Segher Boessenkool <segher@kernel.crashing.org>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v3]: Fix e500 v2 core reboot bug
Date: Wed, 13 Jun 2007 08:28:08 +0200 [thread overview]
Message-ID: <4a8562ccb7046ccde1ab81c725139878@kernel.crashing.org> (raw)
In-Reply-To: <1181715391.9397.16.camel@localhost.localdomain>
> + np = of_find_node_by_name(NULL, "global-utilities");
> + if ((np && of_get_property(np, "fsl,has-rstcr", NULL))) {
If this of_get_property fails...
> + const u32 *prop = of_get_property(np, "reg", NULL);
> + if (prop) {
> + /* map reset control register
> + * 0xE00B0 is offset of reset control register
> + */
> + rstcr = ioremap(get_immrbase() + *prop + 0xB0, 0xff);
> + if (!rstcr)
> + printk (KERN_EMERG "Error: reset control \
> + register not mapped, spinning!\n");
> + }
> + of_node_put(np);
...you still leak a reference.
Segher
next prev parent reply other threads:[~2007-06-13 6:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 2:36 [PATCH v2]: Fix e500 v2 core reboot bug Zang Roy-r61911
2007-05-29 17:38 ` Andy Fleming
2007-05-29 19:29 ` Kumar Gala
2007-05-30 2:34 ` Zang Roy-r61911
2007-05-30 2:40 ` Kumar Gala
2007-05-30 5:46 ` Zang Roy-r61911
2007-05-30 12:25 ` Kumar Gala
2007-05-30 13:49 ` Kumar Gala
2007-05-30 15:21 ` Segher Boessenkool
2007-05-31 5:32 ` Zang Roy-r61911
2007-05-31 5:52 ` Benjamin Herrenschmidt
2007-05-31 3:40 ` Zang Roy-r61911
2007-06-04 8:28 ` Zang Roy-r61911
2007-06-04 8:41 ` Segher Boessenkool
2007-06-04 9:01 ` Zang Roy-r61911
2007-06-04 10:37 ` Segher Boessenkool
2007-06-05 2:15 ` Zang Roy-r61911
2007-05-31 2:38 ` Zang Roy-r61911
2007-06-12 9:08 ` [PATCH v3]: " Zang Roy-r61911
2007-06-12 16:18 ` Timur Tabi
2007-06-13 4:44 ` Segher Boessenkool
2007-06-13 5:45 ` Zang Roy-r61911
2007-06-13 6:24 ` Zang Roy-r61911
2007-06-13 6:43 ` Zang Roy-r61911
2007-06-13 6:57 ` Segher Boessenkool
2007-06-13 7:04 ` Segher Boessenkool
2007-06-13 6:16 ` Zang Roy-r61911
2007-06-13 6:28 ` Segher Boessenkool [this message]
2007-06-13 6:31 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a8562ccb7046ccde1ab81c725139878@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).