From: Benjamin Gray <bgray@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: "ajd@linux.ibm.com" <ajd@linux.ibm.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"ardb@kernel.org" <ardb@kernel.org>,
"jbaron@akamai.com" <jbaron@akamai.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"jpoimboe@kernel.org" <jpoimboe@kernel.org>
Subject: Re: [PATCH v2 3/6] powerpc/module: Optimise nearby branches in ELF V2 ABI stub
Date: Tue, 27 Sep 2022 13:12:18 +1000 [thread overview]
Message-ID: <4afd73392c4a31916e7aaad7767d5e945a40ddb9.camel@linux.ibm.com> (raw)
In-Reply-To: <44761b8c-f51f-ae32-b0f6-d9ab09670f9b@csgroup.eu>
On Mon, 2022-09-26 at 14:49 +0000, Christophe Leroy wrote:
> > + /* Replace indirect branch sequence with direct branch
> > where possible */
> > + if (!create_branch(&direct, jump_seq_addr, addr, 0))
> > + if (patch_instruction(jump_seq_addr, direct))
>
> Why not use patch_branch() ?
I didn't think of it at the time. To get the same abort-if-patch-failed
semantics then the following should work
int err;
...
/* Replace indirect branch sequence with direct branch where
* possible
*/
err = patch_branch(&entry->jump[PPC64_STUB_MTCTR_OFFSET], addr, 0);
if (err && err != -ERANGE)
return 0;
>
next prev parent reply other threads:[~2022-09-27 3:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 6:43 [PATCH v2 0/6] Out-of-line static calls for powerpc64 ELF V2 Benjamin Gray
2022-09-26 6:43 ` [PATCH v2 1/6] powerpc/code-patching: Implement generic text patching function Benjamin Gray
2022-09-26 8:56 ` kernel test robot
2022-09-26 13:28 ` kernel test robot
2022-09-26 14:33 ` Christophe Leroy
2022-09-27 2:57 ` Benjamin Gray
2022-09-27 5:54 ` Christophe Leroy
2022-09-27 6:40 ` Christophe Leroy
2022-09-28 1:30 ` Benjamin Gray
2022-09-28 10:52 ` Christophe Leroy
2022-09-27 7:30 ` Christophe Leroy
2022-09-26 6:43 ` [PATCH v2 2/6] powerpc/module: Handle caller-saved TOC in module linker Benjamin Gray
2022-09-26 6:43 ` [PATCH v2 3/6] powerpc/module: Optimise nearby branches in ELF V2 ABI stub Benjamin Gray
2022-09-26 14:49 ` Christophe Leroy
2022-09-27 3:12 ` Benjamin Gray [this message]
2022-09-26 6:43 ` [PATCH v2 4/6] static_call: Move static call selftest to static_call_selftest.c Benjamin Gray
2022-09-26 14:50 ` Christophe Leroy
2022-09-26 6:43 ` [PATCH v2 5/6] powerpc/64: Add support for out-of-line static calls Benjamin Gray
2022-09-26 13:16 ` Christophe Leroy
2022-09-27 5:18 ` Benjamin Gray
2022-09-27 6:07 ` Christophe Leroy
2022-09-26 14:54 ` Christophe Leroy
2022-09-27 3:21 ` Benjamin Gray
2022-09-27 6:01 ` Christophe Leroy
2022-09-26 6:43 ` [PATCH v2 6/6] powerpc/64: Add tests " Benjamin Gray
2022-09-26 14:55 ` Christophe Leroy
2022-09-27 3:31 ` Benjamin Gray
2022-09-27 6:05 ` Christophe Leroy
2022-09-26 14:19 ` [PATCH v2 0/6] Out-of-line static calls for powerpc64 ELF V2 Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afd73392c4a31916e7aaad7767d5e945a40ddb9.camel@linux.ibm.com \
--to=bgray@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jbaron@akamai.com \
--cc=jpoimboe@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).